bugGNUstep - Bugs: bug #11600, [NSSavePanel...

Group
 
 

bug #11600: [NSSavePanel -browser:isColumnValid:] doesn't detect missing files

Submitter:  Alexander Malmberg <alexm>
Submitted:  Fri 14 Jan 2005 03:53:14 PM UTC
   
 
Category:  Gui/AppKit Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Bug
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Fri 14 Jan 2005 03:53:14 PM UTC, original submission:  

[NSSavePanel -browser:isColumnValid:] currently only checks that all filenames in the column are valid according to the delegate's -panel:shouldShowFilename: method. Thus, it won't notice if there are files in the directory that should be shown but aren't (e.g. because the disk contents changed, or because the delegate's filtering became more permissive).

(Reproduce e.g. with a save panel with a file type popup with entries "All files" and "*.txt only". Go to a directory with non-*.txt files, switch to "*.txt only", switch back to "All files", and the non-*.txt files won't be displayed.)

Since this method is only called from -validateVisibleColumns, and since a proper check here involves reading in the directory, building a new list of files, and comparing, I think we might as well return NO always and just reload the column. However, due to NSBrowser internals, this would cause us to lose the selection every time the columns are validated. Probably best to have NSBrowser preserve the selection, though.

(this is "tests/gui/NSSavePanel/setDelegate_reload.m" in the 'new' test suite)

Alexander Malmberg <alexm>
Group Member

 

Attached Files

This item currently has no attached files.

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

 

Votes

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

History

No changes have been made to this item

Back to the top

Powered by Savane 3.16-11ef.
Corresponding source code