bugGNUstep - Bugs: bug #10214, Patch for GSXML under amd64

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #10214: Patch for GSXML under amd64

Submitted by:  Pete French <minusbat>
Submitted on:  Sun 29 Aug 2004 06:25:09 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Mon 01 Nov 2004 08:10:32 AM UTC, comment #1:

Thanks for the patch.
Rather than change the public API with this patch, I have modified the usage of NSMapTable to (I hope) work properly on a 64bit processor where sizeof(int) != sizeof(void*)
Please let me know if there are any problems with this.

Richard Frith-Macdonald <CaS>
Project Member
Sun 29 Aug 2004 06:25:09 PM UTC, original submission:

The attached patch changes the 'type' from an int
to a long throughout. This is because it is stored in
a void* in the NSMapTable which is longer than an int
on amd64. This may not be a problem when storing, but
could be on retrieval as a void** was being passed with
the address of an int. It also changes the way the hash is
calculated slightly to remove a waning and retain as
much uniqueness as possible.

As the sizeof an int and a long are the same on all
other architectures then this patch does not affect
operation on non amd64 systems in any way. It passes
the guile GSXML test on those systems.

Pete French <minusbat>

 

Attached Files
file #1696:  gsxml.diff added by minusbat (9KiB - application/octet-stream - Patchfile for GSXML.m and GSXML.h)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 01 Nov 2004 08:10:32 AM UTCCaSStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Sun 29 Aug 2004 06:25:09 PM UTCminusbatAttached File-=>Added gsxml.diff, #1625

Back to the top


Powered by Savane 3.1-cleanup1