taskGNU remotecontrol - Tasks: task #12625, Modify COUNT for Maximum #...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

task #12625: Modify COUNT for Maximum # Thermostats

Submitted by:  Stephen H. Dawson <shdawson>
Submitted on:  Tue 21 May 2013 05:53:23 PM UTC  
 
Should Start On: Tue 21 May 2013 04:00:00 AM UTCShould be Finished on: Sun 23 Jun 2013 04:00:00 AM UTC
Category: MySQLPriority: 5 - Normal
Item Group: OperationStatus: Done
Privacy: PublicAssigned to: None
Open/Closed: OpenFixed Release: 1.1
Percent Complete: 100%Planned Release: 1.1

(Jump to the original submission Jump to the original submission)

Tue 24 Sep 2013 04:26:56 PM UTC, comment #8:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Very Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 11:30:18 AM UTC, comment #7:

Please post the version of Windows and Internet Explorer you tested with this code,or if you did not test against Windows and Internet Explorer.

Stephen H. Dawson <shdawson>
Project Administrator
Mon 24 Jun 2013 09:52:13 PM UTC, comment #6:

Hi,

Can you please send me the cleaned up iptstat.sql to try?

Kindly,
SHD

Stephen H. Dawson <shdawson>
Project Administrator
Sun 16 Jun 2013 06:04:03 AM UTC, comment #5:

Hi Stephen, with my update it's possible to handle thousands, In the requested format. Just change your value, 255 to a bigger one. Now, in your setup appears 255 because before my update the field were handled in one byte unsigned, and every higher value were cut to it's maximun, 255. If you just update this value you'll see, also the format, after thousands, 1000 will appear as 1,000.
The type i used, for compatibility in other table on were the same field is used, is Medium Int Unsigned, this means you can handle up to 16777215

Virgilio Lino <virgiliolino>
Project Member
Sat 15 Jun 2013 09:58:39 PM UTC, comment #4:

Hi,

Just emailed you about this. Please review data type, going for thousands and thousands of thermostats, and for display format for index.php and admin.php.

".....Also, make sure we comma-separate the Maximum # Thermostats value by thousands.

We do not want to render:
1000
54000
325000

We do want to render:
1,500
54,000
325,000....."

-SHD

Stephen H. Dawson <shdawson>
Project Administrator
Sat 15 Jun 2013 08:31:01 PM UTC, comment #3:

Hi Stephen, i've done the modifications requested on this ticket. There are mostly updates on the mysql stored procedures, so it's enough to import on the database the sql i'm attaching and update the class lib/User.php. There are no modifications on data, but if you have important information on your db please make a backup before.
After this, you have to overwrite the old lib/User.php.
It should work, please tell me if there are some problems,
thanks
Virgilio

After we find everything is ok, i can attach also the initial import ipstat.sql with the updated data.

(file #28323, file #28324)

Virgilio Lino <virgiliolino>
Project Member
Fri 24 May 2013 11:18:11 AM UTC, comment #2:

http://dev.mysql.com/doc/refman/5.6/en/integer-types.html

Let's discuss the integer type we need to modify this field with.

Stephen H. Dawson <shdawson>
Project Administrator
Tue 21 May 2013 05:56:32 PM UTC, comment #1:

Also, make sure we comma-separate the Maximum # Thermostats value by thousands.

We do not want to render:
1000
54000
325000

We do want to render:
1,500
54,000
325,000

Stephen H. Dawson <shdawson>
Project Administrator
Tue 21 May 2013 05:53:23 PM UTC, original submission:

This is currently set to a maximum of 127. We need to increase this so large scale deployments can use more thermostats.

Stephen H. Dawson <shdawson>
Project Administrator

 

Attached Files
file #28324:  User.php added by virgiliolino (2kB - application/x-php)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by virgiliolino (Updated the item)
  • -unavailable- added by shdawson (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 25 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 24 Sep 2013 04:39:52 PM UTCshdawsonOpen/ClosedClosed=>Open
    Tue 24 Sep 2013 04:38:05 PM UTCshdawsonOpen/ClosedOpen=>Closed
    Tue 24 Sep 2013 04:37:42 PM UTCshdawsonAssigned tovirgiliolino=>None
    Tue 24 Sep 2013 04:36:56 PM UTCshdawsonStatusReady For Test=>Done
    Tue 24 Sep 2013 04:36:34 PM UTCshdawsonStatusDone=>Ready For Test
    Tue 24 Sep 2013 04:35:38 PM UTCshdawsonStatusNone=>Done
      Open/ClosedClosed=>Open
    Tue 24 Sep 2013 04:35:08 PM UTCshdawsonStatusDone=>None
      Open/ClosedOpen=>Closed
    Tue 24 Sep 2013 04:34:36 PM UTCshdawsonOpen/ClosedClosed=>Open
    Tue 24 Sep 2013 04:33:50 PM UTCshdawsonAssigned toNone=>virgiliolino
    Tue 24 Sep 2013 04:32:15 PM UTCshdawsonAssigned toremotecontrol-published=>None
    Tue 24 Sep 2013 04:31:30 PM UTCshdawsonAssigned toNone=>remotecontrol-published
    Tue 24 Sep 2013 04:26:56 PM UTCshdawsonStatusReady For Test=>Done
      Assigned tovirgiliolino=>None
      Open/ClosedOpen=>Closed
      Percent Complete80%=>100%
    Tue 18 Jun 2013 09:44:16 PM UTCshdawsonCategoryNone=>MySQL
    Tue 18 Jun 2013 09:36:24 PM UTCshdawsonFixed ReleaseNone=>1.1
    Sun 16 Jun 2013 08:30:15 PM UTCshdawsonShould be Finished onSun 30 Jun 2013 04:00:00 AM UTC=>Sun 23 Jun 2013 04:00:00 AM UTC
      Assigned toshdawson=>virgiliolino
    Sat 15 Jun 2013 08:31:01 PM UTCvirgiliolinoAttached File-=>Added update_thermostats.sql, #28323
      Attached File-=>Added User.php, #28324
      StatusNeed Info=>Ready For Test
      Assigned tovirgiliolino=>shdawson

    Back to the top


    Powered by Savane 3.1-cleanup