taskGNU remotecontrol - Tasks: task #12521, Add SORTING to all fields in the...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

task #12521: Add SORTING to all fields in the thermostat profile table

Submitted by:  Stephen H. Dawson <shdawson>
Submitted on:  Sun 10 Mar 2013 12:32:22 AM UTC  
 
Should Start On: Sun 23 Jun 2013 04:00:00 AM UTCShould be Finished on: Sun 28 Jul 2013 04:00:00 AM UTC
Category: User InterfacePriority: 5 - Normal
Item Group: NoneStatus: Done
Privacy: PublicAssigned to: None
Open/Closed: OpenFixed Release: 1.1
Percent Complete: 100%Planned Release: 1.1

(Jump to the original submission Jump to the original submission)

Tue 24 Sep 2013 04:46:10 PM UTC, comment #8:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Very Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 05:01:13 PM UTC, comment #7:

Do the fields:
Device Name

Site Name

Model #

...have sorting as well? If not, please add to these fields.

Thanks!

SHD

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 04:59:09 PM UTC, comment #6:

I agree with you about separating the code from the layout, to have a controller as a separate file. MVC Design Pattern for our classes sounds good. We can do this in version 1.2, as discussed.

Thanks!

SHD

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 04:57:01 PM UTC, comment #5:

Hi,

Thanks for the update.

I added the files to the web and ran the sql.

Firefox has the arrows as green. Chrome has the arrows as yellow.

Now, after I add a thermostat, then do sorting, the thermostat is gone. There are 17 thermostats in the thermostat table.

This behavior is duplicated over and over. Something is off with the code on the refreshing of the thermostats after a sort.

2 screen snips attached.

-SHD

(file #28458, file #28459)

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 04:06:39 PM UTC, comment #4:

I'm attaching the last modifications:
-Removed the arrows, instead using unicode chars
-Added all the remaining fields

Please consider that in my previous code i sent you i also added an index_controller.php in the directory inc. Talking again about separation between code and layout, it's very important in my opinion to use the MVC Design Pattern for our classes. One first step is to put all the controller stuff in a separated file, in the same way i think it would be better to make for every file.

(file #28453, file #28454, file #28455, file #28456)

Virgilio Lino <virgiliolino>
Project Member
Sun 30 Jun 2013 12:50:26 PM UTC, comment #3:

If you really want, add some other type of color to the arrow that has the sorting. That will help the user see what column they are sorting by, and if it is ascending or descending.

I recommend using the green color we have in the site them to apply to that arrow that has the sorting. It should stand out nicely in that darker header.

Again, only if you want to.

Thanks!

Stephen H. Dawson <shdawson>
Project Administrator
Sun 30 Jun 2013 12:47:31 PM UTC, comment #2:

Please have:
the arrow on the left to be sort ASCENDING...
.....and.....
the arrow on the right to be sort DESCENDING.

Thanks!

Stephen H. Dawson <shdawson>
Project Administrator
Sun 10 Mar 2013 01:29:35 PM UTC, comment #1:

The sorting selection of the user account needs to have persistence. It would most likely be best to store that sorting choice in the table with the rest of the given user account information. Not certain about this, but it seems like it would be best to store it there. If we put it in the table, we probably should add it to admin.php for increased ease of user administration. This is particularly true with getting a new user up and running, and diagnosing any user problems as they learn GNU remotecontrol.

Easy storage and review of this sorting choice will also allow for the administrators of GNU remotecontrol to easily see, in admin.php, what display languages their users are using and help to see if there is any training needs that could be present. For example, people with the English are OK, but people with another language are struggling. Is it the wording in the display language or another aspect of the program they do not understand? It is a data point that could easily show other UI aspects that need further enhancement for various cultures to use GNU remotecontrol. Or, simply changing a word in the text of the display language.

Stephen H. Dawson <shdawson>
Project Administrator
Sun 10 Mar 2013 12:32:22 AM UTC, original submission:

Add the ability to sort on any field in the grid, both ascending and descending.

A nice colorful UP/DOWN set of triangles, for ascending or descending sort.

Keep the existing sort capability, adding UP/DOWN set of triangles to what we have now.

Stephen H. Dawson <shdawson>
Project Administrator

 

Attached Files
file #28457:  IPThermostatCollection.php added by virgiliolino (2kB - application/x-php)
file #28453:  index_controller.php added by virgiliolino (691B - application/x-php)
file #28454:  master.css added by virgiliolino (5kB - text/css)
file #28455:  index.php added by virgiliolino (57kB - application/x-php)
file #28456:  iptstat.sql added by virgiliolino (49kB - text/x-sql)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by virgiliolino (Updated the item)
  • -unavailable- added by shdawson (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 23 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 24 Sep 2013 04:46:10 PM UTCshdawsonStatusReady For Test=>Done
      Assigned tovirgiliolino=>None
      Percent Complete80%=>100%
    Sun 30 Jun 2013 05:00:10 PM UTCshdawsonSummaryAdd SORTING to all fields in GRID=>Add SORTING to all fields in the thermostat profile table
    Sun 30 Jun 2013 04:57:01 PM UTCshdawsonAttached File-=>Added Screenshot from 2013-06-30 12:52:27.png, #28458
      Attached File-=>Added Screenshot from 2013-06-30 12:53:44.png, #28459
    Sun 30 Jun 2013 04:08:29 PM UTCvirgiliolinoAttached File-=>Added IPThermostatCollection.php, #28457
    Sun 30 Jun 2013 04:07:13 PM UTCvirgiliolinoStatusIn Progress=>Ready For Test
      Percent Complete0%=>80%
    Sun 30 Jun 2013 04:06:39 PM UTCvirgiliolinoAttached File-=>Added index_controller.php, #28453
      Attached File-=>Added master.css, #28454
      Attached File-=>Added index.php, #28455
      Attached File-=>Added iptstat.sql, #28456
    Sat 29 Jun 2013 11:44:28 AM UTCshdawsonShould be Finished onSun 14 Jul 2013 04:00:00 AM UTC=>Sun 28 Jul 2013 04:00:00 AM UTC
    Tue 18 Jun 2013 09:39:13 PM UTCshdawsonFixed ReleaseNone=>1.1
    Sun 16 Jun 2013 08:28:23 PM UTCshdawsonShould Start OnSun 14 Jul 2013 04:00:00 AM UTC=>Sun 23 Jun 2013 04:00:00 AM UTC
      Should be Finished onSat 09 Mar 2013 05:00:00 AM UTC=>Sun 14 Jul 2013 04:00:00 AM UTC
    Sun 16 Jun 2013 08:27:28 PM UTCshdawsonShould Start OnSat 09 Mar 2013 05:00:00 AM UTC=>Sun 14 Jul 2013 04:00:00 AM UTC
    Sun 16 Jun 2013 08:26:57 PM UTCshdawsonPlanned Release1.2=>1.1
    Mon 03 Jun 2013 12:38:03 PM UTCshdawsonStatusNeed Info=>In Progress
    Mon 03 Jun 2013 12:28:17 PM UTCshdawsonAssigned toshdawson=>virgiliolino
    Sun 10 Mar 2013 01:37:25 PM UTCshdawsonCategoryPHP=>User Interface
    Sun 10 Mar 2013 12:43:00 AM UTCshdawsonSummaryAdd sorting to all fields in GRID=>Add SORTING to all fields in GRID

    Back to the top


    Powered by Savane 3.1-cleanup