taskSavannah Administration - Tasks: task #7064, Submission of qemuGL

 
 

task #7064: Submission of qemuGL

Submitter:  Even Rouault <rouault>
Submitted:  Sat 07 Jul 2007 11:06:28 AM UTC
   
 
Should Start On:  Sat 07 Jul 2007 12:00:00 AM UTC Should be Finished on:  Tue 17 Jul 2007 12:00:00 AM UTC
Category:  Project Approval Priority:  * 5 - Normal
Status:  Done Privacy:  Public
Assigned to:  alexshulgin Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 05 Oct 2007 08:17:40 AM UTC, comment #7: 

Hi,

Your project looks OK now -- I'm approving it.  You should receive a mail notification shortly.

However, may be you can fix the copyright notice in kqemu.c to look a more common way before uploading the files to Savannah.  Please use comma as year separator, i.e: "Copyright (c) 2006, 2007" instead of "Copyright (c) 2006/2007".


--
Regards,
Alex

Alexander Shulgin <alexshulgin>
Tue 02 Oct 2007 05:43:55 PM UTC, comment #6: 

Sorry for the delay,

I'm attaching a new version of the patch (qemu_cvs20070907_opengl_patch_20071002.patch.tar.bz2) with appropriate copyright notice in kqemu.c

Best regards,
Even

(file #14063)

Even Rouault <rouault>
Tue 02 Oct 2007 08:43:13 AM UTC, comment #5: 

Hi,

I am waiting for an answer from you.  If within one week I still do not get a reply, I will remove your project.  You will still be able to register it again once you have the time to deal with the registration issues.

Are you still willing to host your project at Savannah?  If not, please tell us -- we don't bite, and it will make us gain time.

--
Alex

Alexander Shulgin <alexshulgin>
Thu 13 Sep 2007 12:01:02 PM UTC, comment #4: 

Thanks for a new patch.

The only thing left undecided is kqemu.c copyrights.  Even if it's not common practice in qemu to add copyright notices into every non-trivially modified file we still have to insist on it if you want to host your patch-project at Savannah.  This is unless you transfer your copyright to qemu author, Fabrice Bellard. :-)

We believe it's crucial to properly attribute every copyrightable
change in order to avoid possible legal problems.  Please refer to the following for more details:
http://www.gnu.org/prep/maintain/html_node/Recording-Contributors.html


Regards,
Alex

Alexander Shulgin <alexshulgin>
Sat 08 Sep 2007 10:13:36 PM UTC, comment #3: 

Hi,

there was already my copyright notice in opengl_client_xfonts.c. I just moved it at the beginning of the file if it makes things clearer...
I added one for opengl_utils.h and regression_test.sh as well, but I feel a bit ridiculous adding a copyright notice on a shell file...and that is only meant to work on my PC!
For kqemu.c, I really don't think it's neccesary. If you look closely at what happens on qemu devel list, you'll see that it is not common practice in qemu development to add your name each time you modify an existing file. Otherwise you'll have hundred lines of names for each file! The general rule is that there is the name of the author of the file, and additional names for authors of really big changes.

I've done these changes on a slighly improved version that adds thread safety. This patch should apply cleanly on recent CVS snapshot

Regards
Even

(file #13900)

Even Rouault <rouault>
Sat 08 Sep 2007 08:18:12 PM UTC, comment #2: 

Hi,

First of all let me apologize for a delay in our previous response.

With the help from my colleague I was able to retrieve the correct CVS snapshot and your patches apply cleanly. :-)

I've identified the following files as changed non-trivially, please add appropriate copyright notices:

kqemu.c

The file target-i386/opengl_client_xfonts.c seems to come from Mesa 3D, but it's unclear whether you modified it or not, if so, please add a copyright notice.

The following files are missing copyright and license notices:

target-i386/opengl_utils.h
target-i386/regression_tests.sh

Please add them as appropriate.


Regards,
Alex

Alexander Shulgin <alexshulgin>
Thu 06 Sep 2007 08:39:55 PM UTC, comment #1: 

Hi,

I'm reviewing your project for approval.

I haven't found the cvs snapshot of qemu from 2007-06-30 as required by your patch, so I took the least recent one from http://qemu-forum.ipi.fi/qemu-snapshots/qemu-snapshot-2007-08-29_05.tar.bz2

The patches applied almost cleanly with only one rejection, so I was able to take a look at the rest of files :-)  Here is the problem file diagnostic:

patching file vl.c
Hunk #1 succeeded at 207 with fuzz 2 (offset 4 lines).
Hunk #2 succeeded at 7066 (offset 379 lines).
Hunk #3 FAILED at 7174.
Hunk #4 FAILED at 7279.
Hunk #5 FAILED at 8056.
3 out of 5 hunks FAILED -- saving rejects to file vl.c.rej

I have found that file target-i386/opengl_utils.h is missing copyright and license notices.  Please add them as appropriate.

Could you please also create a patch against some recent snapshot, so I can take a look at cleanly patched sources.


Kind regards,
Alex

Alexander Shulgin <alexshulgin>
Sat 07 Jul 2007 11:06:28 AM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves or discards the registration.


Registration Administration


While this item will be useful to track the registration process, approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators, effectively logged as site administrators (superuser):



Registration Details


  • Name: qemuGL
  • System Name:  qemugl
  • Type: non-GNU software & documentation
  • License: Expat License (sometime refered to as MIT License) (I don't exclude accepting contributions licenced under other free software licences such as GNU GPL or GNU LGPL)





Description:

Goal




This project is a rather large patch to QEMU emulator (http://fabrice.bellard.free.fr/qemu/) aiming at providing accelerated 3D graphics to the guest of a virtual machine.
At current time, the project is only supporting accelerated OpenGL for i386 GNU/Linux hosts and guests. Windows guests support is highly experimental for the moment. Future directions could be to extend support of hosts and guest to most UNIX-like OS and Windows. Most of the core OpenGL API and extensions (including vendor extensions) has been implemented, enabling to run most major 3D software and games. The ultimate goal would be its inclusion into QEMU baseline.

How does it work ?
------------------
The patch is composed of three parts :
- a patch for QEMU itself that intercepts any call to 'int $0x99' which is the interface I have chosen to dedicate to communication between guest user programs and QEMU.
  The modification of QEMU existing code is very slight.
- an OpenGL 'server' receiving OpenGL calls and executing them with the host GL library (preferably with accelerated drivers)
- an OpenGL-compliant library that must be installed on the
  guest virtual machine.
  This library implements the OpenGL API and send the calls to the QEMU host.

It can also be tested without running into a virtual machine as the server and client can be real TCP/IP server and client programs.


Where to find it ?
------------------
For the moment, the patch lives on http://qemu-forum.ipi.fi/viewtopic.php?t=2984. It has been discussed a bit on qemu devel list : http://lists.gnu.org/archive/html/qemu-devel/2006-11/msg00144.html


Other Software Required:

None except QEMU dependencies.


Even Rouault <rouault>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by alexshulgin (Updated the item)
  • -email is unavailable- added by rouault (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-05 alexshulgin StatusPing-ed Done
        Open/ClosedOpen Closed
    2007-10-02 rouault Attached File- Added qemu_cvs20070907_opengl_patch_20071002.patch.tar.bz2, #14063
    2007-10-02 alexshulgin StatusWait reply Ping-ed
    2007-09-08 rouault Attached File- Added qemu_cvs20070907_opengl_patch_20070908.patch.tar.bz2, #13900
    2007-09-06 alexshulgin StatusNone Wait reply
    2007-09-06 alexshulgin Assigned toNone alexshulgin

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code