taskSavannah Administration - Tasks: task #14793, Submission of fltkal

 
 

task #14793: Submission of fltkal

Submitted by:  Mark J. Olesen <markjolesen>
Submitted on:  Sun 31 Dec 2017 12:07:11 AM UTC  
 
Should Start On:  Sun 31 Dec 2017 12:00:00 AM UTC Should be Finished on:  Wed 10 Jan 2018 12:00:00 AM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  Cancelled Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Closed Effort:  0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 06 Feb 2018 11:47:14 PM UTC, comment #33:

thank you for your patience and time

Mark J. Olesen <markjolesen>
Tue 06 Feb 2018 08:10:54 AM UTC, comment #32:

A boilerplate is a boilerplate: it is to be applied rather than just copied, and applying means carefully reading it and replacing certain texts to fit your situation.

For info on how to apply GNU licenses to your package, see the instructions in the licenses themselves, then, the GNU project maintains a GPL HowTo and a chapter on Legal Matters in Information for Maintainers of GNU Software.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 05 Feb 2018 05:16:45 PM UTC, comment #31:

What worries me is that I am left with code that has an incorrect or incomplete license. From your comments it is not clear what is wrong. You just state that I do not comprehend Savannah policies, which is vague.

Are you aware of a forum or site I can get help in bringing the license into compliance? Apparently, FSF boiler plate text is not enough.

Thanks.

Mark J. Olesen <markjolesen>
Mon 05 Feb 2018 08:51:59 AM UTC, comment #30:

I understand that the job isn't easy, however, it isn't sufficient just to follow my suggestions, you should be willing to follow Savannah policies, and you didn't want to comprehend them.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 04 Feb 2018 09:14:11 PM UTC, comment #29:

I request that this be reopened. I have been following your suggestions. It is difficult because this is a fork of another project so current licensing must be retained.

From your comments, I replaced FooBar with FLTK and you said it was wrong. I then asked what should it be and know you want to close the project.

I hope you reconsider. Thanks for your consideration.

Mark J. Olesen <markjolesen>
Sun 04 Feb 2018 03:27:38 PM UTC, comment #28:

All packages hosted on Savannah should follow its requirements, and one of those requirements is having valid copyright and license notices. If the maintainers of the package don't care to understand what it means (and you evidently don't), the package is in no way going to follow that policy.

Under such circumstances I have few options but to cancel your submission. I'm sure you'll understand my decision.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Fri 02 Feb 2018 10:49:40 AM UTC, comment #27:

see comment #20:

Why, you replaced 'Foobar' with 'FLTK', didn't you?

> What is it supposed to say?

...

Mark J. Olesen <markjolesen>
Fri 02 Feb 2018 10:01:02 AM UTC, comment #26:

> Changed text to read:
>
> You should have received a copy of the GNU Library General Public License
> along with Foobar. If not, see <http://www.gnu.org/licenses/>.


I'm awfully sorry, what has Foobar to do with your library?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 01 Feb 2018 12:26:12 AM UTC, comment #25:

Attempt #8 - following is the tar ball containing all requested changes up to date:

https://savannah.gnu.org/submissions_uploads/fltkal8.tar

Mark J. Olesen <markjolesen>
Wed 31 Jan 2018 03:56:28 PM UTC, comment #24:

Yes, that would be fine.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 30 Jan 2018 11:10:07 AM UTC, comment #23:

Would the following changes be okay?

curhelp.xpm (fl_cursor_help.xpm)
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

curnesw.xpm (fl_cursor_nesw.xpm)
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

curnone.xpm (fl_cursor_none.xpm)
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

curnwse.xpm (fl_cursor_nwse.xpm)
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

curwait.xpm (fl_cursor_wait.xpm)
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

tile.xpm
Copyright 2014 by Bill Spitzak and others.
Licensed under the terms of the FLTK license

FLTK License
December 11, 2001

The FLTK library and included programs are provided under the terms
of the GNU Library General Public License (LGPL) with the following
exceptions:
...

Mark J. Olesen <markjolesen>
Tue 30 Jan 2018 10:17:35 AM UTC, comment #22:

Thank you!

The text of readme files now lists the files with their copyright statements and cites FLTK license, but it doesn't state clearly that the license applies to those files.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 30 Jan 2018 01:03:21 AM UTC, comment #21:

added readme file for xpm files. Eventually, they will be replaced with cursors from KDE or Gnome. However, I decided to leave them for now.

Changed text to read:

You should have received a copy of the GNU Library General Public License
along with Foobar. If not, see <http://www.gnu.org/licenses/>.

latest tarball can be found here:

https://savannah.gnu.org/submissions_uploads/fltkal7.tar

Mark J. Olesen <markjolesen>
Mon 29 Jan 2018 06:04:43 PM UTC, comment #20:

> I used the text your put in comment #13.


Why, you replaced 'Foobar' with 'FLTK', didn't you?

> What is it supposed to say?


It's supposed to state what license is used.

> Is it missing the 'Library' word? Should it say:
> GNU Library General Public License


Quite right.

> I believe everything but tile.xpm can be removed.


Let us inspect the result.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 29 Jan 2018 10:41:38 AM UTC, comment #19:

1. First, the license notices refer to the wrong license: "You should have received a copy of the GNU General Public License along with FLTK. If not, see <http://www.gnu.org/licenses/>."

I used the text your put in comment #13. What is it supposed to say? Is it missing the 'Library' word? Should it say:

GNU Library General Public License

2. Then, the src/ directory contains some XPM files, and they lack any notices (there is no README file in src/). Please check other files as well, I didn't look into them all.

I believe everything but tile.xpm can be removed.

Mark J. Olesen <markjolesen>
Mon 29 Jan 2018 07:42:12 AM UTC, comment #18:

The latest tarball still has some issues.

First, the license notices refer to the wrong license: "You should have received a copy of the GNU General Public License along with FLTK. If not, see <http://www.gnu.org/licenses/>."

Then, the src/ directory contains some XPM files, and they lack any notices (there is no README file in src/). Please check other files as well, I didn't look into them all.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Fri 26 Jan 2018 10:18:14 AM UTC, comment #17:

https://savannah.gnu.org/submissions_uploads/fltkal6.tar

Thanks again for your service.

Mark J. Olesen <markjolesen>
Fri 26 Jan 2018 09:16:06 AM UTC, comment #16:

Could you attach the latest tarball (corresponding to comment #15)?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Fri 26 Jan 2018 12:16:37 AM UTC, comment #15:

It was brought up on the FLTK mailing lists that porsche.xpm may also infringe on registered trademark. So, I removed the file. It has been replaced with an FLTK xpm someone put up. I updated the readme file accordingly.

To summarize:
image files in src have been removed
porsche.xpm has been replaced (readme updated)
modified FSF address to URL and dropped redundant part

Mark J. Olesen <markjolesen>
Thu 25 Jan 2018 02:41:35 PM UTC, comment #14:

I removed the xbm files from the src directory. I am not sure if they were needed. Tracking down the origins and copyright would take sometime. For porsche.xpm in the test directory, I updated the readme.

I went ahead and modified FSF address to the URL and dropped the redundant part.

You can find the latest tarball here:

https://savannah.gnu.org/submissions_uploads/fltkal5.tar

I appreciate your efforts and service. Thank you.

Mark J. Olesen <markjolesen>
Wed 24 Jan 2018 04:39:20 PM UTC, comment #13:

> Do you folks have a tool that scans files?


We do, but it isn't very reliable; I check the files manually.

> Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.


While at it: FSF's address changed twice since then; current versions of the licenses recommend using an URL:

(BTW this would make the subsequent link to http://www.fltk.org/COPYING.php redundant.)

> Image files in this directory are
>
> Copyright 1998-2010 by Bill Spitzak and others.


Could you list each file explicitly? Is there a reasonably easy way to find out their origin and check whether Bill Spitzak is actually a copyright holder?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 23 Jan 2018 03:14:05 PM UTC, comment #12:

I placed a readme file in the src directory:

Image files in this directory are

Copyright 1998-2010 by Bill Spitzak and others.

FLTK License
December 11, 2001

The FLTK library and included programs are provided under the terms
of the GNU Library General Public License (LGPL) with the following
exceptions:

1. Modifications to the FLTK configure script, config
header file, and makefiles by themselves to support
a specific platform do not constitute a modified or
derivative work.

The authors do request that such modifications be
contributed to the FLTK project - send all contributions
through the "Software Trouble Report" on the following page:

http://www.fltk.org/str.php

2. Widgets that are subclassed from FLTK widgets do not
constitute a derivative work.

3. Static linking of applications and widgets to the
FLTK library does not constitute a derivative work
and does not require the author to provide source
code for the application or widget, use the shared
FLTK libraries, or link their applications or
widgets against a user-supplied version of FLTK.

If you link the application or widget to a modified
version of FLTK, then the changes to FLTK must be
provided under the terms of the LGPL in sections
1, 2, and 4.

4. You do not have to provide a copy of the FLTK license
with programs that are linked to the FLTK library, nor
do you have to identify the FLTK license in your
program or documentation as required by section 6
of the LGPL.

However, programs must still identify their use of FLTK.
The following example statement can be included in user
documentation to satisfy this requirement:

[program/widget] is based in part on the work of
the FLTK project (http://www.fltk.org).

This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.

This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.

You should have received a copy of the GNU Library General Public
License along with this library; if not, write to the Free
Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

This library is free software. Distribution and use rights are outlined in
the file "COPYING" which should have been included with this file. If this
file is missing or damaged, see the license at:

http://www.fltk.org/COPYING.php

Please report all bugs and problems on the following page:

http://www.fltk.org/str.php

Mark J. Olesen <markjolesen>
Mon 22 Jan 2018 04:19:49 PM UTC, comment #11:

Thank you.

I have attached another tarball, which can be found here:

https://savannah.gnu.org/submissions_uploads/fltkal4.tar

Do you folks have a tool that scans files? I have gone through the 300+ files manually expanding or adding the license header text. I think the only thing that does not have a license is image files in src:

allfiles.xbm d1_mask.xbm d1.xbm ew_mask.xbm ew.xbm new.xbm ns_mask.xbm ns.xbm up.xbm

I can add a readme file in that directory to handle that case.

Mark J. Olesen <markjolesen>
Mon 22 Jan 2018 09:05:17 AM UTC, comment #10:

Perhaps you attached a wrong file.

What about the rest? Are there any similar issues?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 21 Jan 2018 11:23:43 PM UTC, comment #9:

Sorry about that.

I have attached the modified cmakelis.txt file with changes.

(file #43010)

Mark J. Olesen <markjolesen>
Sun 21 Jan 2018 03:02:17 PM UTC, comment #8:

Thank you!

png/cmakelis.txt still has no copyright notice.

> Let me know if there is anything else. Thanks.


Please let me know if there is anything else: it's your responsibility to follow Savannah policies :)

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Fri 19 Jan 2018 01:54:50 PM UTC, comment #7:

I updated the files in the test directory and png, jpeg, zlib text files.

I also used grep to find references to Linux and then changed it to GNU/Linux.

You can find the latest version here:

https://savannah.gnu.org/submissions_uploads/fltkal3.tar

Let me know if there is anything else. Thanks.

Mark J. Olesen <markjolesen>
Fri 19 Jan 2018 06:52:51 AM UTC, comment #6:

Files like test/tpixmap.cxx still carry the old notice; also, you didn't seem to take into account the note on Linux vs. GNU/Linux usage.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 18 Jan 2018 03:28:15 AM UTC, comment #5:

Please find a new tarball located here:

https://savannah.gnu.org/submissions_uploads/fltkal2.tar

All source and header files have your requested changes. I have expanded the license text including for zlib, png, and jpeg libraries.

Let me know if I missed anything or if there are other compliance issues. Thanks.

Mark J. Olesen <markjolesen>
Wed 17 Jan 2018 10:37:21 PM UTC, comment #4:

I do not mind expanding the license header for fltkal source files.

What about license header for jpeg, png, and zlib source files that are included? They also refer to an external file such as readme for conditions.

Mark J. Olesen <markjolesen>
Wed 17 Jan 2018 05:27:32 PM UTC, comment #3:

I'm also not sure if the license notice in your files is acceptable: it only refers to the file and ignores the recommendations of the license itself.

What would definitely do is putting the canonical LGPL notice with the exceptions in every file.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 15 Jan 2018 11:37:20 PM UTC, comment #2:

The license is a modified LPGL V2:

http://www.fltk.org/COPYING.php

In the root directory of the tarball, there is also a COPYING file.

There are two files missing a license header. They are both in the doc directory named build.md and filemap.md. I am most likely going to change them to dox files and put a license header in them. Let me know if I need to do that prior to approval. All the rest of the files should have an appropriate header describing the copyright and license.

I will be sure to use the term GNU/Linux. Thanks.

Let me know what you need me to do in order to move forward.

Mark J. Olesen <markjolesen>
Mon 15 Jan 2018 05:11:22 PM UTC, comment #1:

Hello, Mark!

Unfortunately, your submission has a few issues to fix.

First, what license are you actually going to use for your package?

Then, please note that Savannah is a forge of the GNU Project. This means that packages hosted here shouldn't refer to GNU/Linux as "Linux".

Also, please make sure that all copyrightable files in your tarball have valid copyright and license notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 31 Dec 2017 12:07:11 AM UTC, original submission:

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details

  • Name: fltkal
  • System Name: fltkal
  • Type: non-GNU software and documentation
  • License: GNU General Public License v2 or later (FLTK uses a modified LGPL V2. See COPYING file.

Allegro is programmed in C, and is giftware. This port does not contain the Allegro library code. It is an external dependency.)


Description:

Fast Light Toolkit (FLTK) port

This is a port of FLTK to FreeDOS using DJGPP and Allegro. However, it will also compile and run on GNU/Linux systems.

FLTK provides a simple, light weight, and easy to use cross platform GUI toolkit. It is programmed in C++. An existing DOS port does not exist.

Other Software Required:

Allegro 4

http://liballeg.org/license.html

(external dependency)

FLTKAL contains code for LIBPNG, JPEG and ZLIB.

LIBPNG

http://www.libpng.org/pub/png/src/libpng-LICENSE.txt

(internal or external dependency)

LIBJPEG

http://ijg.org/
https://fedoraproject.org/wiki/Licensing:IJG?rd=Licensing/IJG

ZLIB

https://www.zlib.net/zlib_license.html

(internal or external dependency)

Other Comments:

Thank you and Happy New Year!

Tarball URL:

https://savannah.gnu.org/submissions_uploads/fltkal.tar

Mark J. Olesen <markjolesen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43010:  cmakelis.txt added by markjolesen (3KiB - text/plain - add license text to cmakelis.txt file)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by markjolesen (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-04 ineiev StatusIn Progress => Cancelled
        Open/ClosedOpen => Closed
    2018-01-21 markjolesen Attached File- => Added cmakelis.txt, #43010
    2018-01-15 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.3