taskSavannah Administration - Tasks: task #14403, Submission of Guile-CV

 
 

task #14403: Submission of Guile-CV

Submitter:  David Pirotte <daviid>
Submitted:  Mon 13 Mar 2017 04:16:15 AM UTC
   
 
Should Start On:  Mon 13 Mar 2017 03:00:00 AM UTC Should be Finished on:  Thu 23 Mar 2017 03:00:00 AM UTC
Category:  Project Approval Priority:  * 5 - Normal
Status:  Done Privacy:  Public
Assigned to:  agn Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 25 Mar 2017 06:39:19 PM UTC, comment #16: 

Hello Assaf,

> The project has been created.


Great, thanks!
David

David Pirotte <daviid>
Sat 25 Mar 2017 02:30:04 AM UTC, comment #15: 

The project has been created.

You should soon receive an email with further instructions.

regards,
 - assaf

Assaf Gordon <agn>
Site Administrator
Fri 24 Mar 2017 01:54:37 PM UTC, comment #14: 

Hello Assaf,

> Please address item #1.


Done.  Here is the git commit log, for info (and save your time):

    Fixing LICENSE for images that come with Guile-CV
   
    * COPYING -> COPYING.LESSER:  Well renamed :)
   
    * COPYING:  New file, containing the latest GPLv3 text.
   
    * LICENSE:  Updated to point to COPYING.LESSER.  Adding a section related
      to images that are distributed with Guile-CV.
   
    * doc/images/blocks.png:
    * doc/images/coins.png:
    * doc/images/gnu.png:
    * doc/images/lenna.png:
    * doc/images/poochyena.png:
    * doc/images/tools.jpg:  Deleted.

> Items #2 and #3 are optional (but highly recommended).


Ok thanks, I'll keep these as they are for now.

> Please upload a new archive to savannah ...


Done:

http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.2.tar.gz
http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.2.tar.gz.sig

Regards,
David

David Pirotte <daviid>
Thu 23 Mar 2017 05:24:34 PM UTC, comment #13: 

Hello David,

Until Guile-CV is accepted as an official gnu program, I'm evaluating it
as non-gnu, according to our (savannah admins') guidelines.

I'm basing my comments on this version:
http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.1.tar.gz

Please also see the automated report at:
https://gnueval.housegordon.org/show/247


1.
There are several binary image files in ./doc/images/ .
Please specify copyright and license information for these files,
and origin if you did not create them.

For example, ./doc/images/gnu.png is the
levitating,meditating gnu from https://www.gnu.org/graphics/meditate.html

Add this information to the README or LICENSE file.
If possible, also embed it as metadata in the files themselves.


2.
For non-gnu programs it is acceptable to have indirect licenses (such as "see file X for license information"),
but it is highly discouraged (for gnu programs I'm not sure it's OK, but I'm not in the GNU evaluation team).

I recommend adding explicit license information to all texi files in the ./doc/ directory.
For example, see the individual texi files in gnulib:
  https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc
  https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/c-strtod.texi

Most of them have a copyright and license as a texinfo comment:
  @c Copyright (C) 2008-2017 Free Software Foundation, Inc.
  @c Permission is granted to copy, distribute and/or modify this document
  @c under the terms of the GNU Free Documentation License, Version 1.3 or
  @c any later version published by the Free Software Foundation; with no
  @c Invariant Sections, no Front-Cover Texts, and no Back-Cover
  @c Texts.  A copy of the license is included in the ``GNU Free
  @c Documentation License'' file as part of this distribution.

Note these are not a texinfo "@copyright{}" command - that command is
to render a copyright notice in the output file.
These comments are meant to be seen be other developers who can use your files.


3.
To make evaluation quicker and easier, it is recommended to use the canonical form
for copyright notices:
   Copyright (C) YEAR, YEAR, YEAR-YEAR  AUTHOR (email)
It is acceptable to make variations (e.g. the author/email on the next line,
and spaces between the dash character in 'YEAR - YEAR') -
but it just makes evaluation harder.
You'll notice that most GNU packages do follow this form closely.
It is recommended to adjust the files in the project to use this canonical form.

Note that there's an additional requirement for official GNU packages
to mention in the README if copyright years use ranges (e.g. YEAR-YEAR).
See here:
  https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html





Please address item #1. Items #2 and #3 are optional (but highly recommended).

Please upload a new archive to savannah with these issues amended to continue with the evaluation.

regards,
 - asssaf


Assaf Gordon <agn>
Site Administrator
Thu 23 Mar 2017 03:19:19 PM UTC, comment #12: 

I'm sorry for your time and for my uncivil tone. I can't handle this request.

Ineiev <ineiev>
Site Administrator
Tue 21 Mar 2017 07:23:37 PM UTC, comment #11: 

Hello Assaf,

> ... Could you open a project page for Guile-CV ...


Gentle Ping...
I really want/need to make this work public now...

Thanks,
David

David Pirotte <daviid>
Sun 19 Mar 2017 10:51:54 PM UTC, comment #10: 

Hello Assaf,

I (strongly) disagree and won't feed such a 'system', I'm sorry.

As far as I'm concerned, Guile-CV has been evaluated, and ready/waiting for its
approval (or not, I'm referring to the step).

> > Could you validate the change of headers that you required,
> > and open a project page for Guile-CV asap, thanks  


> Please remember we are all volunteers here, giving our time to improve
> free-software (just like you do). It helps to keep things courteous instead of
> demanding immediate approval.


Courtesy is my philosophy, and I did not demand 'immediate approval', this is a
(very) unfair rewrite of my above demand which is 'to open a project page as soon as
possible', given the facts: (a) I submitted Guile-CV  January the 31st, its full
evaluation has been completed March the 11th, date at which it entered the  queue
for approval, being informed that it would take at another east 5 weeks; (b) I
decided then to loose my precious time and rewrite its headers, so it can be part of
nongnu in the mean time, and submitted it to Savannah nongnu March the 13th, with a
very clear 'special note'; (c) Pavel did ask Mike, March the 16th: 'Mike, should we just
approve this package?'; (d) Mike's answer being:

"I have not looked at his latest version, but as of the previous, it met all
requirements for the GNU evaluation.  I trust that his changes didn't
introduce any concerns from what he was describing---as long as the
copyright headers look correct, then I'd say you're good to approve it."

(d) Pavel reviewed the headers of all files, thanks, and they are now all
correct.

So, afaic, Guile-CV is ready to be part of nongnu, waiting its approval to part GNU,
maybe, hence my demand:

Could you validate the change of headers that you required, and open a
project page for Guile-CV asap, thanks

Which is extremely polite, and knowing we are all volunteers, used the wording 'as
soon as possible', not 'immediate'.

Regards,
David

David Pirotte <daviid>
Sat 18 Mar 2017 06:22:27 PM UTC, comment #9: 

Hello David,

> I'm sorry Pavel, but Guile-CV already has been evaluated.


There are two options here:
Either guile-cv has been evaluated and accepted as a GNU program,
or it is being evaluated as a non-gnu program.

If it has been accepted as an official GNU program,
we (savannah admin) wait for an official announcement sent to savannah-hackers-private@gnu.org.
Then the project will be approved quickly, without further evaluation on our part.

As long as there's no such announcement, it is not an official gnu program, and a savannah admin evaluates it as  a non-gnu program. Such evaluation is subject to the admin's discretion,
and Pavel is right to require licensing improvements.


As a side note,
I'll say the there were few cases where the gnu evaluation team was less strict in their evaluation of licensing requirements then the savannah team, approving projects in states that I (personally) would not have approved. However that's their prerogative and evaluation is somewhat subject, as recently discussed here:
https://lists.gnu.org/archive/html/savannah-hackers-public/2017-03/msg00007.html .


> Could you validate the change of headers that you required,
> and open a project page for Guile-CV asap, thanks


Please remember we are all volunteers here,
giving our time to improve free-software (just like you do).
It helps to keep things courteous instead of demanding immediate approval.

regards,
 - assaf



Assaf Gordon <agn>
Site Administrator
Sat 18 Mar 2017 04:31:32 PM UTC, comment #8: 

Heya,

> Thank you; unfortunately, some issues persist.


I'm sorry Pavel, but Guile-CV already has been evaluated.

Could you validate the change of headers that you required, and open a project page for Guile-CV asap, thanks

David.


David Pirotte <daviid>
Sat 18 Mar 2017 04:02:15 PM UTC, comment #7: 

Thank you; unfortunately, some issues persist.

Why did you choose this license for your work? Are you sure the LGPLv3+ is what you want? I'm sorry, I can't help asking.

Ineiev <ineiev>
Site Administrator
Sat 18 Mar 2017 01:41:24 PM UTC, comment #6: 

Hello Pavel,

I have just uploaded a new version, which, I believe, fixes all the issues:

    http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.1.tar.gz

WDYT?

Cheers,
David.

David Pirotte <daviid>
Fri 17 Mar 2017 02:35:58 PM UTC, comment #5: 

Hello, David!

> I don't understand what you want here: the copyright is in
> guile-cv.texi If i add it in other file, I have a warning, 'multiple
> @copying...' notice, one for any other file I would define it If I
> uncomment the @insertcopying, it raises a texinfo exception...
>
> What do you expect me to do here?


I assume that you agreed to follow GNU policies. I expect
that you follow Information for Maintainers of GNU software.

It says, "Every nontrivial file needs a license notice as well as the
copyright notice. (Without a license notice giving permission to copy
and change the file, the file is non-free.)". It seems to me that
the documentation is very clear and detailed.  Didn't you read it?

>> INSTALL has an incorrect copyright notice.
>
> afaict, it does not have any copyright notice either


Yes, it has:


Copyright (C) 1994-1996, 1999-2002, 2004-2013 Free Software Foundation,
Inc.


>> Your copy of the LGPLv3 is poorly wrapped; why not use the file from
>> https://www.gnu.org/licenses/lgpl-3.0.txt?
>
> I don't understand either here :). LICENSE refers to COPYING, which is
> a copy of the file you mentioned


No, it isn't an exact copy:


$ wget -q https://www.gnu.org/licenses/lgpl-3.0.txt
$ diff -U2 lgpl-3.0.txt COPYING|head; diff -U2 lgpl-3.0.txt COPYING|tail
--- lgpl-3.0.txt        2010-03-23 23:34:01.000000000 +0000
+++ COPYING     2016-11-06 01:04:47.000000000 +0000
@@ -1,51 +1,52 @@
-                   GNU LESSER GENERAL PUBLIC LICENSE
-                       Version 3, 29 June 2007
+GNU LESSER GENERAL PUBLIC LICENSE

- Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
+published by the Free Software Foundation.

-  If the Library as you received it specifies that a proxy can decide
+If the Library as you received it specifies that a proxy can decide
 whether future versions of the GNU Lesser General Public License shall
 apply, that proxy's public statement of acceptance of any version is
 permanent authorization for you to choose that version for the
-Library.
+Library.
\ No newline at end of file


Ineiev <ineiev>
Site Administrator
Fri 17 Mar 2017 09:27:46 AM UTC, comment #4: 

Hello Pavel,

> Many Texinfo files in doc/ lack licensing notice.


I don't understand what you want here: the copyright is in  guile-cv.texi If i add it in other file, I have a warning, 'multiple @copying...' notice, one for any other file I would define it If I uncomment the @insertcopying, it raises a texinfo exception...

    What do you expect  me to do here?
    What do others (or other packages) do?

> README, NEWS, meta/guile-cv-1.0.pc.in lack both copyright
> and licensing notices.


This is the 3rd package I submit to be part of GNU, no one has ever asked me to add a copyright notice to these file
what would it be like?

> INSTALL has an incorrect copyright notice.


afaict, it does not have any copyright notice either

> Your copy of the LGPLv3 is poorly wrapped; why not use the file from https://www.gnu.org/licenses/lgpl-3.0.txt?


I don't understand either here :). LICENSE refers to COPYING, which is a copy of the file you mentioned

Thanks to give me some more hints here, like an example for each of the remark you made

Happy Hacking,
David

David Pirotte <daviid>
Fri 17 Mar 2017 05:34:34 AM UTC, comment #3: 

Many Texinfo files in doc/ lack licensing notice.

README, NEWS, meta/guile-cv-1.0.pc.in lack both copyright
and licensing notices.

INSTALL has an incorrect copyright notice.

Your copy of the LGPLv3 is poorly wrapped; why not use the file from https://www.gnu.org/licenses/lgpl-3.0.txt? Probably this is why you didn't read it carefully. It's a set of additional terms on top of the GPLv3, so without including the latter the license of the package is incomplete.

Could you fix that?

Ineiev <ineiev>
Site Administrator
Thu 16 Mar 2017 11:02:41 PM UTC, comment #2: 

Pavel:

I have not looked at his latest version, but as of the previous, it met all requirements for the GNU evaluation.  I trust that his changes didn't introduce any concerns from what he was describing---as long as the copyright headers look correct, then I'd say you're good to approve it.


Mike Gerwitz <mikegerwitz>
Site Administrator
Thu 16 Mar 2017 07:37:44 AM UTC, comment #1: 

Mike, should we just approve this package?

Ineiev <ineiev>
Site Administrator
Mon 13 Mar 2017 04:16:15 AM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves or discards the registration.


Registration Administration


While this item will be useful to track the registration process, approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators, effectively logged as site administrators (superuser):



Registration Details


  • Name: Guile-CV
  • System Name:  guile-cv
  • Type: non-GNU software and documentation
  • License: GNU Lesser General Public License (n/a)





Description:

Guile-CV
a Computer Vision functional programming library for Guile

Guile-CV is a Computer Vision functional programming library for the Guile Scheme language.  Guile-CV is based on Vigra (Vision with Generic Algorithms).  It comprises a direct binding to Vigra_c (a C wrapper to some of the Vigra functionality), and a higher level API written in Guile Scheme.



Other Software Required:


Autoconf >= 2.69
Automake >= 1.14

Guile >= 2.0.13
http://www.gnu.org/software/guile
LGPLv2+

Vigra >= 1.11.0
http://ukoethe.github.io/vigra/
the LICENSE file says: 'identical to the MIT X11 License'

Vigra_c
https://github.com/BSeppke/vigra_c
the LICENSE file says: The MIT License (MIT)



Other Comments:

Special Note:

This project is under GNU evaluation already, and the technical evaluation has been completed. I have just been told that it will take another 5 weeks at least, due to backlog ... This is all fine, but I wantto make this project public as soon as possible, hence my demand here.

The GNU evaluator is Mike Gerwitz <mtg@gnu.org>, and I did ask him if I could pass his contact to you guys, so you may save quite a bit of time: Mike has done the hard work already :), please get in touch with him for the technical evaluation part.

Since Mike did the evaluation, I uploaded a new version with all the changes required so Guile-CV follows the 'nongnu project style' (headers and copyright have all been changed, as well as all occurrences of GNU Guile-CV -> Guile-CV.

The tarball and sigfile are here:

http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.tar.gz
http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.tar.gz.sig


[ GPG Key: A3057AD7
[ gpg --keyserver keys.gnupg.net --recv-keys A3057AD7



Tarball URL:

http://download.savannah.nongnu.org/releases/grip/guile-cv/guile-cv-0.1.3.tar.gz


David Pirotte <daviid>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by agn (Posted a comment)
  • -email is unavailable- added by daviid (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-03-25 agn StatusWait reply Done
        Open/ClosedOpen Closed
    2017-03-23 agn StatusNone Wait reply
    2017-03-23 agn Assigned toNone agn
    2017-03-23 ineiev Carbon-CopyRemoved 46355 -
    2017-03-23 ineiev StatusIn Progress None
        Assigned toineiev None
    2017-03-17 ineiev Carbon-CopyRemoved -email is unavailable- -
    2017-03-17 ineiev Carbon-CopyRemoved 88130 -
    2017-03-16 ineiev StatusNone In Progress
        Assigned toNone ineiev
    2017-03-16 ineiev Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code