taskGNU Health - Tasks: task #13888, Include taxes on from the service...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #13888: Include taxes on from the service lines to invoice

Submitted by:  Luis Falcon <meanmicio>
Submitted on:  Thu 11 Feb 2016 12:38:06 PM UTC  
Votes:  100  
 
Should Start On: Thu 11 Feb 2016 12:00:00 AM UTCShould be Finished on: Tue 07 Feb 2017 12:00:00 AM UTC
Category: FunctionalityPriority: 5 - Normal
Status: In ProgressPrivacy: Public
Percent Complete: 70%Assigned to: Luis Falcon <meanmicio>
Open/Closed: OpenRelease: 3.1.0
Module: health_services

Wed 17 Feb 2016 10:22:41 AM UTC, comment #4:

Update the tax summary automatically (except customer rules). Thanks Oscar ! The rules should be computed at invoice model.

Luis Falcon <meanmicio>
Project AdministratorIn charge of this item.
Thu 11 Feb 2016 06:06:38 PM UTC, comment #3:

Thanks for the feedback !

For me, that does is not optimal in terms of scalability. I see now that Tryton has the similar code in Purchase and Sales. So, for every document involving invoices (including health services model) we would have to enter all those attributes and methods related to tax rules computation. That does not scale well.

I propose that the tax rules should be calculated at invoice validation, in a similar fashion as the computation of Tax lines total.

So, at the invoice model, we have the party (and its tax rules), we have the product (and its associated taxes). So it should be feasible to compute the tax substitution rules, and will make the code much leaner and scalable.

Is it possible ?

Luis Falcon <meanmicio>
Project AdministratorIn charge of this item.
Thu 11 Feb 2016 01:22:38 PM UTC, comment #2:

I re-open this issue because the solution proposed doesn't take care of the customer_tax_rule.
The best is to replicate the design of Sale.on_change_product.

Cédric Krier <cedk>
Thu 11 Feb 2016 12:43:27 PM UTC, comment #1:

Done in changeset changeset 2389:40f8af6c84f2

http://hg.savannah.gnu.org/hgweb/health/rev/40f8af6c84f2

Luis Falcon <meanmicio>
Project AdministratorIn charge of this item.
Thu 11 Feb 2016 12:38:06 PM UTC, original submission:

For those lines in the health service document that are marked to be incoiced, product taxes should be included on the resulting invoice.

Thanks Carlos Sotelo and Fernando Sánchez for pointing it out !

Bests,

Luis Falcon <meanmicio>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cedk (Posted a comment)
  • -unavailable- added by csotelo (Voted in favor of this item)
  • -unavailable- added by meanmicio (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 100 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Feb 2016 01:22:38 PM UTCcedkStatusDone=>In Progress
      Percent Complete100%=>70%
    Thu 11 Feb 2016 12:55:22 PM UTCcsoteloCarbon-Copy-=>Added csotelo
    Thu 11 Feb 2016 12:43:27 PM UTCmeanmicioStatusNone=>Done
      Percent Complete0%=>100%
      ReleaseNone=>3.1.0

    Back to the top


    Powered by Savane 3.1-cleanup1