taskGNU remotecontrol - Tasks: task #12611, Move the Session Initialization...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

task #12611: Move the Session Initialization into global.php

Submitted by:  Stephen H. Dawson <shdawson>
Submitted on:  Sun May 12 17:50:07 2013  
 
Should Start On: Sun May 12 04:00:00 2013Should be Finished on: Sun Jun 30 04:00:00 2013
Category: PHPPriority: 5 - Normal
Item Group: NoneStatus: Done
Privacy: PublicAssigned to: None
Open/Closed: ClosedFixed Release: 1.1
Percent Complete: 100%Planned Release: 1.1

Sat Apr 23 16:14:46 2016, comment #5:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson <shdawson>
Project Administrator
Tue Sep 24 16:42:01 2013, comment #4:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Very Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson <shdawson>
Project Administrator
Sun Jun 30 11:31:07 2013, comment #3:

What did you specifically change in this file?

How has your performance changed, if at all, after this change?

Please post the version of Windows and Internet Explorer you tested with this code,or if you did not test against Windows and Internet Explorer.

Stephen H. Dawson <shdawson>
Project Administrator
Mon Jun 24 21:50:12 2013, comment #2:

Virgilio,

Hi. Would you please be so kind as to try this change on your end? Please let me know the outcome of that test.

Kindly,
SHD

Stephen H. Dawson <shdawson>
Project Administrator
Tue May 21 15:18:29 2013, comment #1:

I just installed GNU remotecontrol with latest SVN onto a new box. Had trouble with setting up first user. Trouble was the index.php did not refresh with new user info after setting up user in admin.php. I used the pull-down to select another language, and all populated as expected in index.php.

Since Travis probably has the closest perspective right now on the impact memory variables with his software thermostat effort, I am assigning this ticket to him.

Travis, please edit the cod as you suggested and post to SVN...after you are convinced there are no side effects from this change happening in the web server log. Please email me if you run into any new problems/concerns/thoughts.

Thanks!

Stephen H. Dawson <shdawson>
Project Administrator
Sun May 12 17:50:07 2013, original submission:

index.php is currently setting up the session:

@ $currentUser = new User($_SERVER['PHP_AUTH_USER']);
$_SESSION['User'] = $currentUser;

Navigating to admin.php before going to index.php with an empty session causes:

Notice: Undefined index: User in /usr/local/share/remotecontrol/lib/Common.php on line 50

Recommendations:
-Monitoring the error log to ensure there are no side effects.
-Even though it may "appear" to work, moving things like session initialization, require_once statements, etc. to other process points can create some strange side effects or cause some underlying PHP errors.

Stephen H. Dawson <shdawson>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by virgiliolino (Updated the item)
  • -unavailable- added by shdawson (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Apr 23 16:14:46 2016shdawsonOpen/ClosedOpen=>Closed
    Tue Sep 24 16:42:01 2013shdawsonStatusReady For Test=>Done
      Assigned tovirgiliolino=>None
      Percent Complete90%=>100%
    Sat Jun 29 20:58:08 2013virgiliolinoStatusIn Progress=>Ready For Test
      Percent Complete0%=>90%
    Mon Jun 24 21:50:11 2013shdawsonAssigned toshdawson=>virgiliolino
    Tue Jun 18 21:36:40 2013shdawsonFixed ReleaseNone=>1.1
    Sun Jun 16 20:32:42 2013shdawsonAssigned totravispaul=>shdawson
    Tue May 21 15:18:29 2013shdawsonStatusNeed Info=>In Progress
      Assigned toNone=>travispaul

    Back to the top


    Powered by Savane 3.1-cleanup