taskGNU remotecontrol - Tasks: task #12611, Move the Session Initialization...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #12611: Move the Session Initialization into global.php

Submitted by:  Stephen H. Dawson DSL <shdawson>
Submitted on:  Sun 12 May 2013 05:50:07 PM UTC  
 
Should Start On:  Sun 12 May 2013 04:00:00 AM UTC Should be Finished on:  Sun 30 Jun 2013 04:00:00 AM UTC
Category:  PHP Priority:  5 - Normal
Item Group:  None Status:  Done
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Fixed Release:  1.1
Percent Complete:  100% Planned Release:  1.1

Sat 23 Apr 2016 04:14:46 PM UTC, comment #5:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson DSL <shdawson>
Project Administrator
Tue 24 Sep 2013 04:42:01 PM UTC, comment #4:

I bear witness and certify I have personally tested these changes made to GNU remotecontrol. I affirm the changes made to the code:
-achieve the functionality of the stated requirements;
-succeed during operation; and
-cause no anxiety.

I approve this code.

Thank you to everyone for working on this modification.

Very Respectfully,
//SHD//
Stephen H. Dawson

Stephen H. Dawson DSL <shdawson>
Project Administrator
Sun 30 Jun 2013 11:31:07 AM UTC, comment #3:

What did you specifically change in this file?

How has your performance changed, if at all, after this change?

Please post the version of Windows and Internet Explorer you tested with this code,or if you did not test against Windows and Internet Explorer.

Stephen H. Dawson DSL <shdawson>
Project Administrator
Mon 24 Jun 2013 09:50:12 PM UTC, comment #2:

Virgilio,

Hi. Would you please be so kind as to try this change on your end? Please let me know the outcome of that test.

Kindly,
SHD

Stephen H. Dawson DSL <shdawson>
Project Administrator
Tue 21 May 2013 03:18:29 PM UTC, comment #1:

I just installed GNU remotecontrol with latest SVN onto a new box. Had trouble with setting up first user. Trouble was the index.php did not refresh with new user info after setting up user in admin.php. I used the pull-down to select another language, and all populated as expected in index.php.

Since Travis probably has the closest perspective right now on the impact memory variables with his software thermostat effort, I am assigning this ticket to him.

Travis, please edit the cod as you suggested and post to SVN...after you are convinced there are no side effects from this change happening in the web server log. Please email me if you run into any new problems/concerns/thoughts.

Thanks!

Stephen H. Dawson DSL <shdawson>
Project Administrator
Sun 12 May 2013 05:50:07 PM UTC, original submission:

index.php is currently setting up the session:

@ $currentUser = new User($_SERVER['PHP_AUTH_USER']);
$_SESSION['User'] = $currentUser;

Navigating to admin.php before going to index.php with an empty session causes:

Notice: Undefined index: User in /usr/local/share/remotecontrol/lib/Common.php on line 50

Recommendations:
-Monitoring the error log to ensure there are no side effects.
-Even though it may "appear" to work, moving things like session initialization, require_once statements, etc. to other process points can create some strange side effects or cause some underlying PHP errors.

Stephen H. Dawson DSL <shdawson>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by virgiliolino (Updated the item)
  • -email is unavailable- added by shdawson (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-04-23 shdawson Open/ClosedOpen => Closed
    2013-09-24 shdawson StatusReady For Test => Done
        Assigned tovirgiliolino => None
        Percent Complete90% => 100%
    2013-06-29 virgiliolino StatusIn Progress => Ready For Test
        Percent Complete0% => 90%
    2013-06-24 shdawson Assigned toshdawson => virgiliolino
    2013-06-18 shdawson Fixed ReleaseNone => 1.1
    2013-06-16 shdawson Assigned totravispaul => shdawson
    2013-05-21 shdawson StatusNeed Info => In Progress
        Assigned toNone => travispaul

    Back to the top


    Powered by Savane 3.3