helpGNU ccRTP - Support: sr #105229, SingleRTPSessionPool is not thread...

 
 

sr #105229: SingleRTPSessionPool is not thread safe

Submitted by:  Jörgen Terner <jorter>
Submitted on:  Wed 15 Mar 2006 10:32:05 AM UTC  
 
Category: NonePriority: 5 - Normal
Severity: 4 - ImportantStatus: Done
Privacy: PublicAssigned to: None
Open/Closed: OpenOperating System: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 16 May 2006 03:31:00 PM UTC, comment #1:

Hi, I've just commited this patch (and the one for
scheduling packets by timestamp in session pools) to CVS.
Les us know if you have additional comments or if there is
any issue.

Sorry for the delay and thanks a lot!

Federico Montesino Pouzols <fedemp>
Project Member
Wed 15 Mar 2006 10:32:05 AM UTC, original submission:

I've tried to use the SingleRTPSessionPool. After several crashes I realized that it is not thread safe. Insertions and deletions are safe but the main loop is not! There is little point in protecting insertions and deletions if the code that reads the list is not protected.

The list of sessions is not the only problem. Add and remove modifies the variables used in the call to select, so after a call to select the recvSocketSet can be modified before it is used.

I've attached my modifications to the pool that seems to run ok.

Jörgen Terner <jorter>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #3883:  pool.h added by jorter (6kB - text/plain - Modified thread safe session pool)
file #3882:  pool.cpp added by jorter (9kB - text/plain - Modified thread safe session pool.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 16 May 2006 03:31:00 PM UTCfedempStatusNone=>Done
  Carbon-Copy-=>Added -unavailable-
Wed 15 Mar 2006 10:32:58 AM UTCjorterAttached File-=>Added pool.h, #217
Wed 15 Mar 2006 10:32:05 AM UTCjorterAttached File-=>Added pool.cpp, #216

Back to the top


Powered by Savane 3.1-cleanup