mainautogen - Support: sr #109050, guile pkg-config usage is flaky

 
 

sr #109050: guile pkg-config usage is flaky

Submitter:  Mike Frysinger <vapier>
Submitted:  Wed 25 May 2016 07:12:01 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 25 May 2016 07:13:30 PM UTC, comment #1: 
Mike Frysinger <vapier>
Wed 25 May 2016 07:12:01 PM UTC, original submission:  

this commit is a bit problematic:
http://git.savannah.gnu.org/cgit/autogen.git/commit/?h=3dcd713db7f53d0afa21fc9089477ecbbb9b266a

(1)
it shouldn't be using "pkg-config".  instead, call PKG_PROG_PKG_CONFIG in configure.ac (or maybe do AC_REQUIRE([PKG_PROG_PKG_CONFIG])), and then use $PKG_CONFIG.

(2)
the output of --cflags-only-I can be empty when guile is installed in the standard system path.  i guess what you really want to be doing is:
  $PKG_CONFIG --variable=includedir ...

(3)
rather than running awk on the version.h file directly, can't you delay all of that to compile time ?
#define GUILE_VERSION ((SCM_MAJOR_VERSION << 20) | (SCM_MINOR_VERSION << 12) | SCM_MICRO_VERSION)

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by vapier (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code