mainSavannah Administration - Support: sr #108630, delete user doesn't

 
 

sr #108630: delete user doesn't

Submitter:  Karl Berry <karl>
Submitted:  Thu 14 Aug 2014 10:35:21 PM UTC
   
 
Category:  Savannah website Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  ineiev
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 15 Nov 2018 04:57:50 PM UTC, comment #7: 

I've just pushed a commit to use user_delete on siteadmin/userlist.php as well. if FSF people want data of deleted accounts, their sysadmins should pull Savannah backups; Savannah admins don't need access to that data.

Closing.

Ineiev <ineiev>
Site Administrator
Tue 19 Aug 2014 09:03:14 PM UTC, comment #6: 

Indeed, in terms of the English words, I'd expect "delete" to remove all the personal data and "suspend" to keep it.  Hmm.

I can theoretically imagine wanting to suspend an account without deleting the data, but it's never come up (for me) in practice.

So if the user is not a member of any groups and has no tracker item, etc., I guess I don't object to (a) merging the delete and suspend states, and (b) removing personal data for both.

If the user has any such items, I think we should look at the situation and not just blow them away.

As I recall, rms and others strongly suggested retaining a web-inaccessible copy of data that is removed, somewhere/somehow ...

Thanks,
Karl

Karl Berry <karl>
Site Administrator
Tue 19 Aug 2014 11:29:22 AM UTC, comment #5: 

Hello,

There is a function to delete spam accounts
in frontend/php/include/user.php, user_delete().
the function isn't used anywhere else; it clears
user's data like real name and email and removes the user
from all groups; and sets status to 'S'(uspended).

So I wonder whether we really want to
(0) distingish between deleted and suspended accounts;
(1) keep personal data in deleted accounts.

Ineiev <ineiev>
Site Administrator
Sat 16 Aug 2014 07:55:20 AM UTC, comment #4: 

I modified some code on frontend. the real name may show up in something like assigned tasks, bugs &c, this is still to be checked.

Ineiev <ineiev>
Site Administrator
Fri 15 Aug 2014 08:28:45 PM UTC, comment #3: 

yes, the user page is good now.

did you fix it, or was it like that already?

i swear yesterday when i looked at it in a new browser, not logged into savannah, all the info was showing up.

maybe deleting him from the groups had some effect.

thanks,
k

Karl Berry <karl>
Site Administrator
Fri 15 Aug 2014 06:33:29 PM UTC, comment #2: 

I think the first part must work (i.e. account data aren't shown unless requested by superusers).

Ineiev <ineiev>
Site Administrator
Fri 15 Aug 2014 03:40:17 AM UTC, comment #1: 

I'll try to implement this.

Ineiev <ineiev>
Site Administrator
Thu 14 Aug 2014 10:35:21 PM UTC, original submission:  

Hi friends - as we saw on savannah-help-private, a user requested his (old, inactive) account be deleted.  I saw no reason not to do so, so I tried: as superuser in the web interface, I went to https://savannah.nongnu.org/siteadmin/userlist.php?user_name_search=ROCE (there is only one user there -- I'm trying to avoid saying his username or real name, Streisand, etc.) and did "delete".  and in fact its status is deleted and the user does not show up in a normal search for "people".  So I think the delete did what it's intended to do.

However, the user page, https://savannah.gnu.org/users/USERNAME, is still there with all the same information. (And doing an obvious google search will find it.)  This does not seem right, and is not what the user wanted.  It would be better if the web page just said "account deleted" with no real name, no date, no anything.

Would someone like to implement this?  I mean, I could zap him out of the databases, but That Seems Wrong :).

A second, separate, issue: the user in question was also a member of two groups (gnubik and aim) and setting the "delete" status did not remove the user from those groups.
This also seems wrong to me.  In any case, for now we should be aware that the group removals need to be done manually, off https://savannah.nongnu.org/siteadmin/usergroup.php?user_id=NNNNN.

Thanks,
Karl

Karl Berry <karl>
Site Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by karl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-15 ineiev StatusIn Progress Done
        Open/ClosedOpen Closed
    2014-08-15 ineiev StatusNone In Progress
    2014-08-15 ineiev Assigned toNone ineiev

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code