mainSavannah Administration - Support: sr #104562, CVS Commit Diff Emails should be...

 
 

sr #104562: CVS Commit Diff Emails should be Generated with -N Option

Submitter:  Derek Robert Price <dprice>
Submitted:  Mon 15 Aug 2005 04:41:24 AM UTC
   
 
Category:  Source code repositories - developer access Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 05 Jun 2006 02:26:40 PM UTC, comment #6: 

Thanks again, Sylvain!

Derek Robert Price <dprice>
Sat 03 Jun 2006 06:30:03 PM UTC, comment #5: 

Derek fixed the bug :) New log_accum is installed.

Sylvain Beucler <Beuc>
Wed 08 Mar 2006 12:54:08 PM UTC, comment #4: 

I am not arguing against unified diffs.  I am actually arguing for `cvs diff -uN', as I prefer unified diffs as well.  This causes contents to be generated for new and removed diffs, rather than a one line "filex was added" or whatever it is.  Thus the entire commit can be reviewed via the email.

If diffs were generated with -N, commit emails could also be passed whole cloth to patch to recreate the commit in a workspace based just prior to the commit, including new and removed files.

Derek Robert Price <dprice>
Wed 08 Mar 2006 12:59:11 AM UTC, comment #3: 

The MH-E project (emacs/lisp/mh-e) much prefers unified diffs and are currently getting them. We would not at all like to see that changed.

Objective: Unified diffs take a lot less disk space.

Subjective: Unified diffs are much easier to read.

Obviously, if all of the members of a particular project want a particular style of diff, and this can be delivered without affecting other projects, then there is no problem. I'm just wary of sweeping changes.

Bill Wohler <wohler>
Wed 12 Oct 2005 01:43:37 PM UTC, comment #2: 

Excuse me, I meant to send the link to log_accum.pl (http://savannah.nongnu.org/cgi-bin/viewcvs/cvs/ccvs/contrib/log_accum.pl), not commit_prep, but the rest of what I said should still apply.

Derek Robert Price <dprice>
Wed 12 Oct 2005 01:39:26 PM UTC, comment #1: 

The best way to fix this would be unify with the version of commit_prep.pl from CVS (http://savannah.nongnu.org/cgi-bin/viewcvs/cvs/ccvs/contrib/commit_prep.pl). It has many bug fixes and enhancements over the version Savannah is currently using, including this fix (note that several changes are hidden behind the file renames since this script was maintained for some time as commit_prep.in in the CVS repository).

The easiest way to fix this, if you are not ready to try and unify, would be to pass in %{sVv} instead of %s from CVSROOT/commitinfo and parse the "old" and "new" version numbers which would then be passed in from each file.  Then, when "old" is "NONE", then diff -N against the "0" revision (this works for added and removed files).

Derek Robert Price <dprice>
Mon 15 Aug 2005 04:41:24 AM UTC, original submission:  

With the `-N' option added to `cvs diff', the contents of new and removed files will be shown in the commit diff emails that are currently being generated.  This should probably apply to all projects, but I will be satisfied if it only applies to the diff emails generated for the "cvs" project <https://savannah.nongnu.org/projects/cvs/>.  The `-N' option may be applied to all generated diffs, as it is harmless when the diff is not of a new or removed file.

(Currently, empty diff emails are being generated for new and removed files - I would like the content to be presented in the emails generated for the cvs project and think this behavior would be fairly universally well received.)

Derek Robert Price <dprice>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follows 1 latest change.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-03 Beuc Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code