helpSavannah Administration - Support: sr #109487, Lost password link redirects to...

 
 

sr #109487: Lost password link redirects to home page (confusingly)

Submitted by:  Carlo Zancanaro <czan>
Submitted on:  Tue 03 Apr 2018 10:56:06 PM UTC  
 
Category:  Savannah website Priority:  5 - Normal
Severity:  1 - Wish Status:  None
Assigned to:  None Operating System:  GNU/Linux
Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 06 Apr 2018 03:29:26 AM UTC, comment #1:

I just tried the lost password recovery and I agree that it is less than nice the way it is working now. Thank you for your patch suggestion. You have distinguished yourself!

I tried your suggestion however and something else seems to be needed as that line does not seem to be the line that is executed upon lost password recovery. I might be getting confused by something however such as some cache that I haven't flushed. I will need to dig deeper.

In any case I made your suggested change (with a slight modification) as a test to try it out to line 56 (actually 51 in Assaf's "agn/test2" branch currently being run) and it didn't get executed.

session_redirect("https://savannah.gnu.org/account/login.php");

The session_redirect routine is a thin wrapper around sending the Location: header and exiting as one might expect. As such it needs to be a full URL. Yet when I tried to trigger the behavior I was redirected back to the root page and not to the login page. Huh? And so now I don't know if this was an incorrect test on my part or if something else is happening. Your suggested patch seems to be in the right place. I'll keep looking. But I wanted to encourage you as your suggestion seems spot on.

This also reminds us that the branch needs to be updated and merged back into master.

Bob Proulx <rwp>
Site Administrator
Tue 03 Apr 2018 10:56:06 PM UTC, original submission:

I noticed that after I reset my password it returned me to https://savannah.gnu.org (ie. the root page), while leaving me logged out. This was slightly confusing, as I wasn't sure if I had been logged in or not.

I think it would make more sense to redirect to the login page (or to automatically log the user in).

From a brief look at the source, changing
lostlogin.php on line 56 to add "account/login.php" might do it.

Carlo Zancanaro <czan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rwp (Posted a comment)
  • -email is unavailable- added by czan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    No changes have been made to this item

    Back to the top


    Powered by Savane 3.3