helpautogen - Support: sr #109050, guile pkg-config usage is flaky

 
 

sr #109050: guile pkg-config usage is flaky

Submitted by:  Mike Frysinger <vapier>
Submitted on:  Wed 25 May 2016 07:12:01 PM UTC  
 
Category: NonePriority: 5 - Normal
Severity: 3 - NormalStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenOperating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 25 May 2016 07:13:30 PM UTC, comment #1:

sorry, wrong commit. i meant this one:
http://git.savannah.gnu.org/cgit/autogen.git/commit/?h=ca3dc1411d789cdb218eb401c96c557cd04ff051

Mike Frysinger <vapier>
Wed 25 May 2016 07:12:01 PM UTC, original submission:

this commit is a bit problematic:
http://git.savannah.gnu.org/cgit/autogen.git/commit/?h=3dcd713db7f53d0afa21fc9089477ecbbb9b266a

(1)
it shouldn't be using "pkg-config". instead, call PKG_PROG_PKG_CONFIG in configure.ac (or maybe do AC_REQUIRE([PKG_PROG_PKG_CONFIG])), and then use $PKG_CONFIG.

(2)
the output of --cflags-only-I can be empty when guile is installed in the standard system path. i guess what you really want to be doing is:
$PKG_CONFIG --variable=includedir ...

(3)
rather than running awk on the version.h file directly, can't you delay all of that to compile time ?
#define GUILE_VERSION ((SCM_MAJOR_VERSION << 20) | (SCM_MINOR_VERSION << 12) | SCM_MICRO_VERSION)

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vapier (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1