mainSavannah Administration - Support: sr #108964, Changing email address doesn't work

 
 

sr #108964: Changing email address doesn't work

Submitter:  Justus Winter <teythoon>
Submitted:  Fri 05 Feb 2016 09:57:58 AM UTC
   
 
Category:  Savannah website Priority:  5 - Normal
Severity:  4 - Important Status:  None
Privacy:  Public Assigned to:  None
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 09 Feb 2016 12:29:18 AM UTC, comment #7: 

1) i defined the php $title.

2) looking at the code, i see that what happens is that the new address receives email with a confirmation link (maybe yours got filtered as spam? that is common ...), and the old address receives email with a discard link.  that actually makes some sense.  i added a sentence to the description on the web page about it.  the text of the email msgs could be improved too.

3) many more error checks could/should be done -- using an invalid confirmation hash makes it think the process is starting over (or something), invalid email addresses (no @) are allowed, etc.  but, i'm not likely to ever get there.  oh well.

closing this one.  thanks again.

Karl Berry <karl>
Site Administrator
Mon 08 Feb 2016 10:06:50 AM UTC, comment #6: 

Cool, thanks for looking into this Karl :)

Justus Winter <teythoon>
Sun 07 Feb 2016 11:13:24 PM UTC, comment #5: 

hi justus - i got the resend, thanks.  i see the change did not actually go through, so i manually changed the email on your account to the requested address (@gnupg ...). 

i agree the email is surprising, as written.  maybe there is an opt-in link missing. i don't look forward to trying to figure out what's going on, but thanks for the report :).

regarding text going away when copying, i suggest checking "show feedback in relative position" on https://savannah.gnu.org/my/admin/, which will make the results be normal text instead of the pseudo-fancy dynamic boxes.  if i'm understanding what's going on.

(i also recommend "use the stone-age menu" for less surprising mousing and context-changing.)

happy hacking.


Karl Berry <karl>
Site Administrator
Sun 07 Feb 2016 09:24:21 AM UTC, comment #4: 

Hi Karl,

I just tried again, with the same result, and bounced you the message.  Also, I just noticed I didn't really read the message.

So when I requested the change the page notification reads

"Database updated, mail sent to X, mail sent to Y, follow the instructions to complete the change."  (paraphrased, it went away when I clicked on it to copy it)

Then the email reads

"Someone, presumably you, has requested a change of email address on Savannah.
If it wasn't you, maybe someone is trying to steal your account...

Your current address is X, the supposedly new
address is Y.

If you did not request that change, please visit the following URL to discard
the email change and report the problem to us:

https://savannah.gnu.org/my/admin/change.php?item=email&confirm_hash=<somehash>"

So I have to do nothing to allow the change and visit the URL to discard the request?  If so, then please accept my apologies for not reading the message more carefully. The php error still stands of course, and all the other such confirmation messages are opt-in, not opt-out.

Justus Winter <teythoon>
Sun 07 Feb 2016 12:59:35 AM UTC, comment #3: 

p.s. can you please send me (off-web) a copy of the confirmation email? it will help me track things down more quickly.  i'm karl@gnu.org.  thanks.

Karl Berry <karl>
Site Administrator
Sun 07 Feb 2016 12:56:58 AM UTC, comment #2: 

hi justus - thanks for the report. i'll see if i can discern anything in the php, though i'm under the (mistaken?) impression that many people have changed their email addresses, so it's kind of puzzling.

anyway, in the interests of moving things along, please tell me your old and desired new addresses and i'll change it manually.

best,
karl

Karl Berry <karl>
Site Administrator
Fri 05 Feb 2016 10:01:58 AM UTC, comment #1: 

Actually, the second error message says line 579.

Justus Winter <teythoon>
Fri 05 Feb 2016 09:57:58 AM UTC, original submission:  

I tried to change my email address, got the email with the confirmation link, clicked on it, and got to a page titled "My Account Configuration" with

Notice: Undefined variable: title in /usr/src/savane/frontend/php/my/admin/change.php on line 575

being displayed twice.  Changing the mail address didn't work.

Justus Winter <teythoon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by karl (Posted a comment)
  • -email is unavailable- added by teythoon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-09 karl Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code