mainOATH Toolkit - Support: sr #108736, memory corruption after...

 
 

sr #108736: memory corruption after pskc_build_xml()

Submitter:  Jaroslav Škarvada <yarda>
Submitted:  Fri 30 Jan 2015 01:39:20 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  jas
Open/Closed:  Closed Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 11 Nov 2020 05:08:35 PM UTC, comment #1: 

Thank you for the patch!  I have applied it.

Simon Josefsson <jas>
Group administrator
Fri 30 Jan 2015 01:39:20 PM UTC, original submission:  

Original bug report including patch by the reporter (David Woodhouse):
https://bugzilla.redhat.com/show_bug.cgi?id=1129491

In short:
In pskc_build_xml() a new xmlDoc is built and the old one is freed, but there are still references into the old xmlDoc.

According to David:
Actually, retaining the original xmldoc seems like a nice and simple approach. Although it's not as efficient as fixing all the pointers up...

Attached is patch from David retaining the original xmldoc.

Jaroslav Škarvada <yarda>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32947:  oath-toolkit-2.4.1-retain-original-xmldoc.patch added by yarda (1KiB - application/x-php - Fix proposed by David Woodhouse)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jas (Posted a comment)
  • -email is unavailable- added by yarda (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-11 jas Open/ClosedOpen Closed
    2020-11-11 jas StatusNone Done
        Assigned toNone jas
    2015-01-30 yarda Attached File- Added oath-toolkit-2.4.1-retain-original-xmldoc.patch, #32947

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code