mainGnuTLS - Support: sr #108037, gnutls_cpuid assembler code...

 
 

sr #108037: gnutls_cpuid assembler code follows incorrect calling convention on Windows x64

Submitter:  Mann Ern Kang <mannern>
Submitted:  Wed 25 Apr 2012 03:25:56 AM UTC
   
 
Category:  Core library Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  nmav
Open/Closed:  Closed Operating System:  Microsoft Windows
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 25 Apr 2012 10:04:15 AM UTC, comment #3: 

Thank you applied.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Wed 25 Apr 2012 09:45:54 AM UTC, comment #2: 

Hi Nikos,

Attaching the modified cpuid-x86_64.pl file. It was just a problem with the tag on the gnutls_cpuid function: it should have been @function instead of @abi-omnipotent, to direct x86_64-xlate.pl to generate the appropriate function prologue and epilogue for Windows.

Cheers,
Mann Ern

(file #25727)

Mann Ern Kang <mannern>
Wed 25 Apr 2012 07:48:42 AM UTC, comment #1: 

Hello Mann,
 Thanks for the patch. This file is auto-generated from perlasm (the same as used in openssl) at:
http://git.savannah.gnu.org/gitweb/?p=gnutls.git;a=blob;f=devel/perlasm/cpuid-x86_64.pl;hb=HEAD
If you could provide a patch for that file I'd be grateful.

regards,
Nikos

Nikos Mavrogiannopoulos <nmav>
Group administrator
Wed 25 Apr 2012 03:25:56 AM UTC, original submission:  

The gnutls_cpuid function in file lib\accelerated\x86\coff\cpuid-x86-64-coff.s follows the Linux parameter passing convention instead of the Windows x64 one, resulting in a crash (access violation) if hardware acceleration is enabled on a Windows x64 build of gnutls.

Attaching a patch. This is my first time submitting to gnutls so please let me know if I missed out anything :)

Mann Ern Kang <mannern>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25727:  cpuid-x86_64.pl added by mannern (2KiB - application/octet-stream)
file #25725:  cpuid-x86-64-coff.s added by mannern (1KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nmav (Posted a comment)
  • -email is unavailable- added by mannern (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-03 nmav Open/ClosedOpen Closed
    2012-04-25 nmav StatusNone Done
        Assigned toNone nmav
    2012-04-25 mannern Attached File- Added cpuid-x86_64.pl, #25727
    2012-04-25 mannern Attached File- Added cpuid-x86-64-coff.s, #25725

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code