helpCompact Disc Input and Control Library - Support: sr #107643, [patch] Missing HAVE_ROCK checks


sr #107643: [patch] Missing HAVE_ROCK checks

Submitted by:  None
Submitted on:  Sat 02 Apr 2011 01:33:46 AM UTC  
Category: NonePriority: 5 - Normal
Severity: 3 - NormalStatus: Duplicate
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Originator Email: -unavailable-Open/Closed: Closed
Operating System: Microsoft Windows

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Thu 16 May 2013 02:21:40 AM UTC, comment #1:

Sorry for the very very late response.

Git logs show that the change to src/util.c goes back to git commit 95f087cd from 2008-11-29 00:56:26 -0500

And the change to lib/iso9660/iso9660.c goes back to 9fff09c8 of 2010-03-23 16:29:27 both well before this submission.

Perhaps you were using a very old copy of libcdio?

At any rate, if this is still a problem post new patches. And please more of the full path starting from libcdio.

Again, sorry for not noticing this sooner.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Sat 02 Apr 2011 01:33:46 AM UTC, original submission:

Some areas of the code assume that Rock Ridge support is enabled without checking that HAVE_ROCK is defined. I have attached two patches to fix the problem.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #23075:  iso9660.c.diff added by None (439B - application/octet-stream)
file #23076:  libcdio-util.c.diff added by None (504B - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by None (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 16 May 2013 02:22:11 AM UTCrockyStatusNone=>Duplicate
      Assigned toNone=>rocky
    Sat 02 Apr 2011 01:33:46 AM UTCNoneAttached File-=>Added iso9660.c.diff, #23075
      Attached File-=>Added libcdio-util.c.diff, #23076

    Back to the top

    Powered by Savane 3.1-cleanup1