patchGNU Zile (Zile implements Lua Editors) - Patches: patch #8007, Use posix.pipeline

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8007: Use posix.pipeline

Submitted by:  Reuben Thomas <rrt>
Submitted on:  Tue 09 Apr 2013 11:45:00 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Thu 11 Apr 2013 09:38:02 PM UTC, comment #4:

I've filed a bug against luaposix: https://github.com/luaposix/luaposix/issues/81

Reuben Thomas <rrt>
Project Administrator
Thu 11 Apr 2013 08:51:13 PM UTC, comment #3:

After investigation, it seems there's a bug in the way posix.pipeline saves and restores stdout. I can't see what it is at present.

I've updated the patch to use single quotes so it doesn't confuse the Lisp parser.

(file #27845)

Reuben Thomas <rrt>
Project Administrator
Thu 11 Apr 2013 01:44:27 PM UTC, comment #2:

Is the bogus output going to stderr, i.e. perhaps the redirect 2>&1 isn't working for some reason?

Reuben Thomas <rrt>
Project Administrator
Thu 11 Apr 2013 03:26:11 AM UTC, comment #1:

Hi Reuben,

Thanks for the patch!

I've cleaned up and committed my patch queue on the Zile lua branch to make zmacs run correctly on stdlib-35 (unreleased!) and luaposix-5.1.28 (from master, after my bugfix).

After applying your patch, shell-command still works correctly, but shell-command-on-region screws up the terminal somehow. Please fix and resubmit!

Cheers,
Gary

Gary V. Vaughan <gary>
Project Administrator
Tue 09 Apr 2013 11:45:00 AM UTC, original submission:

This patch uses posix.pipeline to simplify shell-command-on-region.

pipe_command becomes show_shell_output, as for shell-command we simply use io.shell.

Reuben Thomas <rrt>
Project Administrator

 

Attached Files
file #27845:  use_pipeline.patch added by rrt (3kB - text/x-diff - Updated patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gary (Posted a comment)
  • -unavailable- added by rrt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Apr 2013 08:51:13 PM UTCrrtAttached File-=>Added use_pipeline.patch, #27845
    Thu 11 Apr 2013 08:50:33 PM UTCrrtAttached File#27826=>Removed
    Tue 09 Apr 2013 11:45:00 AM UTCrrtAttached File-=>Added use_pipeline.patch, #27826

    Back to the top


    Powered by Savane 3.1-cleanup