patchGNU Octave - Patches: patch #8004, image package: imtransform -...

 
 

patch #8004: image package: imtransform - various updates

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Sun 07 Apr 2013 02:31:01 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Carnë Draug <carandraug>Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 29 Apr 2013 12:55:41 PM UTC, comment #7:

That's great. Thank you. Patch applied at https://sourceforge.net/p/octave/code/11856

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Sun 28 Apr 2013 12:54:05 PM UTC, comment #6:

Attached is a patch that adds tests for findbounds.m and imstransform.m. The documentation of imtransform.m is modified to reflect the fact that multiple output variables can be returned.

Pantxo

(file #27964)

Pantxo Diribarne <pantxo>
Project Member
Sun 28 Apr 2013 02:35:11 AM UTC, comment #5:

By the way, I made some small changes on the input checking of findbounds. There was also an error imtransform.

Would you be able to write some tests for this functions?

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Sun 28 Apr 2013 02:32:23 AM UTC, comment #4:

Apologies for the very late reply. I have finally commited the changes.

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Mon 08 Apr 2013 09:20:02 PM UTC, comment #3:

Attached is a patch where demos work on current octave release.

Pantxo

(file #27813)

Pantxo Diribarne <pantxo>
Project Member
Mon 08 Apr 2013 07:02:31 AM UTC, comment #2:

I'll write new demos that don't depend on the patched imshow and submit a new patch.

Pantxo Diribarne <pantxo>
Project Member
Mon 08 Apr 2013 01:26:07 AM UTC, comment #1:

I don't think it's a good idea to apply a patch that is dependent on a development version. This is dependent on a patch that hasn't even been accepted so I will wait until the other gets resolved and a new Octave version is out.

Is it possible to change this patch so that is not dependent on the other?

Carnë Draug <carandraug>
Project MemberIn charge of this item.
Sun 07 Apr 2013 02:31:01 PM UTC, original submission:

Attached is an svn changeset for imtransform related functions:
- maketform is modified so as to accept input/output control points as second and third argument
- findbounds is added,
- imtransform is added.

The demos in imtransform currently rely on this patch http://savannah.gnu.org/patch/?7981
I know it is not a good idea to include features that may not be released for a while but without it, it becomes very difficult to have comprehensive demos.

Pantxo

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27964:  imtransform_tests.patch added by pantxo (4kB - text/x-patch)
file #27813:  imtformpatch_r2.diff added by pantxo (19kB - text/x-patch)
file #27805:  imtformpatch.diff added by pantxo (18kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 28 Apr 2013 12:54:05 PM UTCpantxoAttached File-=>Added imtransform_tests.patch, #27964
    Sun 28 Apr 2013 02:35:10 AM UTCcarandraugStatusNone=>Done
      Assigned toNone=>carandraug
      Open/ClosedOpen=>Closed
    Mon 08 Apr 2013 09:20:02 PM UTCpantxoAttached File-=>Added imtformpatch_r2.diff, #27813
    Mon 08 Apr 2013 01:26:07 AM UTCcarandraugSummaryimtransform : various updates=>image package: imtransform - various updates
    Sun 07 Apr 2013 02:31:01 PM UTCpantxoAttached File-=>Added imtformpatch.diff, #27805

    Back to the top


    Powered by Savane 3.1-cleanup