patchGNU Autoconf Archive - Patches: patch #7911, AX_PTHREAD handles AIX incorrectly

 
 

patch #7911: AX_PTHREAD handles AIX incorrectly

Submitted by:  None
Submitted on:  Thu 03 Jan 2013 10:32:07 AM UTC  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Feb 2013 10:04:35 AM UTC, comment #3:

Pushed in e40cfd6e5038b4e42c2ae9fb3c567b8deeee921b. Thank you very much, guys!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Fri 04 Jan 2013 09:16:45 PM UTC, comment #2:

I'd make a few changes; see attached.

  • Keep the not-GCC check
  • Furthermore, do this only on AIX
  • Quoting tweaks
  • Sorted the big case pattern and fixed a couple typos
  • Use AS_EXECUTABLE_P() instead of "test -x"

Thomas's patch also addresses /usr/vac/bin/ not being in the user's PATH, which is in fact the case in my employer's production AIX environment.

(file #27202)

Daniel Richard G. <iskunk>
Fri 04 Jan 2013 04:59:08 PM UTC, comment #1:

Hi Steven, hi Daniel,

do you have an opinion with regard to this patch? Is it okay for you to apply it?

Peter Simons <simons>
Project AdministratorIn charge of this item.
Thu 03 Jan 2013 10:32:07 AM UTC, original submission:

The PTHREAD_CC compiler is currently unconditionally replaced with xlc_r on AIX unless set by the user.

This is erroneous because most compiler wrappers on AIX have a specific feature set not necessarily matched by xlc_r.

I have therefore improved the corresponding shell code to match the wrapper actually used to its corresponding thread-safe variant and would like to see the change made publically available.

Legalese: you are free to distribute and/or use the corresponding submission under the following license:

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved. This file is offered as-is,
without any warranty.

Regards,
Thomas Jahns

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27190:  0001-Improve-pthread-compiler-elicitation-for-AIX.patch added by None (1kB - text/x-diff - created with git format-patch vs. cbc823484f repository main-line)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by iskunk (Updated the item)
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by simons
  • -unavailable- added by simons
  • -unavailable- added by None (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 02 Feb 2013 10:25:08 AM UTCsimonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sat 02 Feb 2013 10:04:35 AM UTCsimonsStatusIn Progress=>Ready For Test
    Fri 04 Jan 2013 09:16:45 PM UTCiskunkAttached File-=>Added 0001-Improve-pthread-compiler-elicitation-for-AIX.v2.patch, #27202
    Fri 04 Jan 2013 04:59:08 PM UTCsimonsStatusNone=>In Progress
      Assigned toNone=>simons
      Carbon-Copy-=>Added steven g. johnson
      Carbon-Copy-=>Added daniel richard g.
    Thu 03 Jan 2013 10:32:07 AM UTCNoneAttached File-=>Added 0001-Improve-pthread-compiler-elicitation-for-AIX.patch, #27190

    Back to the top


    Powered by Savane 3.1-cleanup