patchGNU Autoconf Archive - Patches: patch #7673, AX_BOOST_PYTHON should use quotes...

 
 

patch #7673: AX_BOOST_PYTHON should use quotes when setting CPPFLAGS

Submitted by:  None
Submitted on:  Mon 21 Nov 2011 04:06:16 PM UTC  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 21 Nov 2011 06:39:32 PM UTC, comment #1:

Your patch has been pushed to the Git repository in commit 2fca6b72c6a18efd00712c185f22efb4d61c725c. Thank you very much for the bug fix!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Mon 21 Nov 2011 04:06:16 PM UTC, original submission:

Hello! AX_BOOST_PYTHON does not use quotes when setting CPPFLAGS, which can cause problems if CPPFLAGS is already defined to something. For example:

1) Imagine CPPFLAGS starts as "-DTEST=1 -DTEST=2"
2) "CPPFLAGS_SAVE=$CPPFLAGS" will expand to "CPPFLAGS_SAVE=-DTEST=1 -DTEST=2" which will try to run the program "-DTEST=2" with a temporary CPPFLAG_SAVE environment variable.

1) Imagine CPPFLAGS starts as "-DTEST=1"
2) You'll get past the previous problem because CPPFLAGS is only one word.
3) But "CPPFLAGS=-I$PYTHON_INCLUDE_DIR $CPPFLAGS" will expand to something like "CPPFLAGS=-I/usr/include/python2.7 -DTEST=1" and you hit the same issue again. The program "-DTEST=1" will not be found.

The attached patch fixes AX_BOOST_PYTHON for me. A quick grep showed that some other macros might be affected too, so you might want to do a general check.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24414:  ax_boost_python.diff added by None (848B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 02 Dec 2011 03:16:35 PM UTCsimonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Mon 21 Nov 2011 06:39:32 PM UTCsimonsStatusNone=>Ready For Test
      Assigned toNone=>simons
    Mon 21 Nov 2011 04:06:16 PM UTCNoneAttached File-=>Added ax_boost_python.diff, #24414

    Back to the top


    Powered by Savane 3.1-cleanup