patchGnash - The GNU Flash player - Patches: patch #6334, Caching in gnash::stream

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #6334: Caching in gnash::stream

Submitted by:  Sandro Santilli <strk>
Submitted on:  Fri 07 Dec 2007 11:56:50 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Wed 12 Dec 2007 03:24:00 PM UTC, comment #2:

attached an updated patch cleanly applying to head, and raising cache capacity to 512 bytes.

(file #14608)

Sandro Santilli <strk>
Project Member
Fri 07 Dec 2007 12:04:28 PM UTC, comment #1:

Started a wiki page as a place for redesign discussion:
http://wiki.gnashdev.org/wiki/index.php/SWF_Loading

Sandro Santilli <strk>
Project Member
Fri 07 Dec 2007 11:56:50 AM UTC, original submission:

This patch implements a fixed-size cache in gnash::stream class
filled on first bitwise read and used till empty.
The patch gave me no regressions and dramatically
reduced tu_file based seeks (sometimes triggering complete
decompression from start).

With this patch loading the ninja movie performs 80k calls
to low-level input rather then 18m (1/1000). Only tested the
case in which low-level call is std_read_func (loading from filesystem), no idea what would that mean for network-loaded
SWFs.

Note that the bitwise reading functions in this patch are not
optimized so you don't see a big speed improvement, anyway
the patch provides a cache which may be used to implement those
improvements.

I'm suspending further work on it as I think we need an
to take a top-down design of data flow to really optimize
buffers (to avoid the data to be copied in memory between
buffers).

Sandro Santilli <strk>
Project Member

 

Attached Files
file #14608:  CachingStream2.patch added by strk (13kB - text/x-patch)
file #14584:  CachingStream.patch added by strk (13kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Submitted the item)
  • -unavailable- added by strk
  • -unavailable- added by strk
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 12 Dec 2007 03:24:00 PM UTCstrkAttached File-=>Added CachingStream2.patch, #14608
    Fri 07 Dec 2007 11:56:50 AM UTCstrkAttached File-=>Added CachingStream.patch, #14584
      Carbon-Copy-=>Added udog
      Carbon-Copy-=>Added zoulunkai

    Back to the top


    Powered by Savane 3.1-cleanup