patchmake - Patches: patch #2608, Patch to uppercase environment...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #2608: Patch to uppercase environment variable names on input

Submitted by:  None
Submitted on:  Mon 09 Feb 2004 11:00:01 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenFixed Release: None

Mon 19 Jul 2010 12:25:21 AM UTC, comment #2:

Can someone familiar with issue on Windows comment as to whether this patch still needed or desirable?

Paul D. Smith <psmith>
Project Administrator
Thu 12 Feb 2004 06:23:14 PM UTC, comment #1:

Hi; I have no problem with this change if the Windows users agree: the Windows port is more or less developed by concensus. You should contact the -unavailable- mailing list and see what people think.

Paul D. Smith <psmith>
Project Administrator
Mon 09 Feb 2004 11:00:01 PM UTC, original submission:

One challenging aspect of a port of GNU make to Win32 has been what to do with Win32's case-retentive (but not case-sensitive) environment. I suggest that one good way of handling this problem is to simply uppercase all environment variable names when they are merged into the make database. That way, makefile writers on Win32 can just assume that all environment variable names are uppercase. While this may seem nasty at first, we must consider the fact that one cannot enter VarName, varname, and VARNAME at the same time. Furthermore, if you set a variable called VarName=Something, then later, in the same environment, set VARNAME=Something (or SomethingElse), the variable name case is retained from the first entry! This being the case, it's far better just to uppercase them all on input. The other option would be to perform case-insensitive string comparisons on variable names, but the make variable name comparison code doesn't differentiate between variables that came from the environment and those defined internally, so this becomes problematic. A better approach is to simply normalize environment variable names and document this fact to Win32 GNU make users.

Anonymous

 

Attached Files
file #6890:  diff.txt added by None (516B - text/plain - diff output between make 3.80 distribution and modified 3.80 distribution)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 09 Feb 2004 11:00:01 PM UTCNoneAttached File-=>Added diff.txt, #2695

    Back to the top


    Powered by Savane 3.1-cleanup