patchGNU Octave - Patches: patch #8372, Added New Functions in Mapping

 
 

patch #8372: Added New Functions in Mapping

Submitter:  None
Submitted:  Tue 04 Mar 2014 09:29:25 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  philipnienhuis Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 03 Apr 2015 09:13:08 PM UTC, comment #6: 

Hi Pooja,

Took a little time but I have pushed your contributions. See:
http://hg.code.sf.net/p/octave/mapping

Apart from a little editing of NEWS hunk (due to intermediate contributions by me the NEWS file was changed too much) all your changesets applied flawlessly.
Kudos for neatly following Octave coding style.
Thanks!

Philip Nienhuis <philipnienhuis>
Group Member
Fri 27 Mar 2015 08:45:54 PM UTC, comment #5: 

Oopsie Pooja,

Wrong bug report, I meant omment #4 for patch #8377.
Apologies for the confusion.

Your contributions are next on my review list ...

Philip Nienhuis <philipnienhuis>
Group Member
Fri 27 Mar 2015 08:41:05 PM UTC, comment #4: 

Hi Felipe and Sandeep:

I've further converted your functions to Octave coding style, see attached patch.

Some remarks:

  • Where are the functions myassert.m and convert_to_cartesian.m ?


  • Please review licenses for get_J2.m (lacking altogether), get_ellipsoid.m, get_sinefun.m and geodetic2ned.m

Would you agree with GPL-3?

  • Furthermore there's one (the last) test in get_ellipsoid.m that seems to run only in Matlab?


I hope to be able to include these functions in the next mapping package release (within -say- 3 weeks or so).
Could you please review my attach patch fix the above issues and supply a new patch on top of mine before mid-April, please?

Thanks


(file #33470)

Philip Nienhuis <philipnienhuis>
Group Member
Tue 24 Mar 2015 10:10:47 PM UTC, comment #3: 

I'm having a look at them, together with some patches from patch #8377
May take some time (it's already over a year old, I know)

Philip Nienhuis <philipnienhuis>
Group Member
Wed 05 Mar 2014 06:34:51 AM UTC, comment #2: 

I have added some comments in the scripts(submitted as patch #8371 and #8372) for better readability.

Thanks,
Pooja Rao

Anonymous
Tue 04 Mar 2014 08:50:02 PM UTC, comment #1: 

These new function files also contain some simple tests. Thanks!

-Pooja

Anonymous
Tue 04 Mar 2014 09:29:25 AM UTC, original submission:  

Added functions rad2km, sm2rad, sm2deg, nm2rad, nm2deg in the mapping package. Updated the INDEX and NEWS files too. I forgot to add the file for tracking and hence the two .diff files.

Thanks,
Pooja Rao

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33470:  mapping_pkg_PRN.patch added by philipnienhuis (79KiB - application/x-download)
file #30919:  fun_km2rad.diff added by None (3KiB - text/x-diff - Moved km2rad from patch #8371 to #8372 )
file #30889:  test_format_chngd.diff added by None (4KiB - text/x-diff - Chnaged test format so tests could be run interactively without problems)
file #30800:  docstr_added.diff added by None (4KiB - text/x-diff - Hi, I added a little more descriptive docstrings as suggested by Juan Pablo Carbajal. -Pooja)
file #30777:  comments_added.diff added by None (5KiB - text/x-diff - I have added some comments to the the functions that I implemented in patch #8371 and #8372)
file #30766:  mapping_new_funcs.diff added by None (11KiB - text/x-diff)
file #30767:  INDEX_NEWS_updated.diff added by None (906B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-03 philipnienhuis StatusIn Progress Done
        Assigned toNone philipnienhuis
        Open/ClosedOpen Closed
    2015-03-27 philipnienhuis StatusNeed Info In Progress
    2015-03-27 philipnienhuis Attached File- Added mapping_pkg_PRN.patch, #33470
        StatusIn Progress Need Info
    2015-03-24 philipnienhuis StatusNone In Progress
    2014-03-16 None Attached File- Added fun_km2rad.diff, #30919
    2014-03-14 None Attached File- Added test_format_chngd.diff, #30889
    2014-03-06 None Attached File- Added docstr_added.diff, #30800
    2014-03-05 None Attached File- Added comments_added.diff, #30777
    2014-03-04 None Attached File- Added mapping_new_funcs.diff, #30766
        Attached File- Added INDEX_NEWS_updated.diff, #30767

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code