patchGNU Octave - Patches: patch #8354, Removed unneeded old file...

 
 

patch #8354: Removed unneeded old file (tempnam.c)

Submitter:  Lasse Schuirmann <sils1297>
Submitted:  Mon 24 Feb 2014 09:10:46 AM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 26 Feb 2014 05:23:53 AM UTC, comment #3: 

I pushed your change with a modified commit message.

Thanks.

John W. Eaton <jwe>
Group administrator
Tue 25 Feb 2014 04:00:49 PM UTC, comment #2: 

Here is the complete patch. Sorry for the inconvenience and thanks for the hints.

(file #30689)

Lasse Schuirmann <sils1297>
Mon 24 Feb 2014 04:34:55 PM UTC, comment #1: 

I suppose it is OK to remove this replacement function now since it is supposed to be provided by the C89 library and probably every system conforms to C89 now.

If you want to do a complete job, then you should also remove the corresponding tempname.c file that provides the definition of __stdio_gen_tempname (only used by the replacement tempnam function) and also the check for tempnam in configure.ac.

John W. Eaton <jwe>
Group administrator
Mon 24 Feb 2014 09:10:46 AM UTC, original submission:  

The file tempnam.c is currently completely unused. Octave compiles well without it. It contains the tempnam function with is available via stdio.h [1]. (Which is used and marked obsolete. [1]) This was probably not the case in 1995 when the file was created.

[1] http://linux.die.net/man/3/tempnam

Lasse Schuirmann <sils1297>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30686:  rem_tempnam_c.diff added by sils1297 (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by sils1297 (Submitted the item)
  • -email is unavailable- added by sils1297
  • -email is unavailable- added by sils1297
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-26 jwe StatusNone Done
        Open/ClosedOpen Closed
    2014-02-25 sils1297 Attached File- Added tempnam_tempname_removal.patch, #30689
    2014-02-24 sils1297 Attached File- Added rem_tempnam_c.diff, #30686
        Carbon-Copy- Added sils1297
        Carbon-Copy- Added siko1056

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code