GNU tar - Patches: patch #8269, fixes for various Parfait errors
You are not allowed to post comments on this tracker with your current authentication level.
patch #8269: fixes for various Parfait errors
Submitter: | Jiri Kukacka <kukackajiri> | ||
Submitted: | Thu 09 Jan 2014 12:56:58 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Wont Do | Privacy: | Public |
Assigned to: | gray | Open/Closed: | Closed |
Discussion locked!
Thu 09 Jan 2014 03:30:59 PM UTC, comment #1: |
Sergey Poznyakoff <gray> |
Thu 09 Jan 2014 12:56:58 PM UTC, original submission:
Hi,
|
Jiri Kukacka <kukackajiri> |
Attached Files
file #30235: 04-parfait_errors_annotations.patch added by kukackajiri (407B - application/octet-stream)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-02-04 | gray | Open/Closed | Open | Closed | |
Discussion Lock | None | Locked | |||
2014-01-09 | gray | Status | In Progress | Wont Do | |
2014-01-09 | gray | Status | None | In Progress | |
Assigned to | None | gray | |||
2014-01-09 | kukackajiri | Attached File | - | Added 03-parfait_errors_fix.patch, #30234 | |
Attached File | - | Added 04-parfait_errors_annotations.patch, #30235 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Thanks for your efforts. I applied two fixes (see commit 481572c63f5a259f1338a1b74e2dee304bd0df0b). Regarding the rest:
1. All fixes related to checking for NULL return from find_next_block() are located in functions which work when creating/updating archives. In this case find_next_block() never returns NULL. It exits immediately on any errors instead.
2. Fixed to tar_copy_str and string_to_chars are plainly wrong. First argument to both functions should never be NULL. If it is, that means a programming error and tar is intended to coredump in that case, instead of silently ignoring the error.