patchGNU Octave - Patches: patch #8004, image package: imtransform -...

 
 

patch #8004: image package: imtransform - various updates

Submitter:  Pantxo Diribarne <pantxo>
Submitted:  Sun 07 Apr 2013 02:31:01 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  carandraug Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 29 Apr 2013 12:55:41 PM UTC, comment #7: 

That's great. Thank you. Patch applied at https://sourceforge.net/p/octave/code/11856

Carnë Draug <carandraug>
Group Member
Sun 28 Apr 2013 12:54:05 PM UTC, comment #6: 

Attached is a patch that adds tests for findbounds.m and imstransform.m. The documentation of imtransform.m is modified to reflect the fact that multiple output variables can be returned.

Pantxo


(file #27964)

Pantxo Diribarne <pantxo>
Group Member
Sun 28 Apr 2013 02:35:11 AM UTC, comment #5: 

By the way, I made some small changes on the input checking of findbounds. There was also an error imtransform.


error ("imtransform: expect 1 or 3 elements real vector for %s", 3, "fillvalues")


Would you be able to write some tests for this functions?

Carnë Draug <carandraug>
Group Member
Sun 28 Apr 2013 02:32:23 AM UTC, comment #4: 

Apologies for the very late reply. I have finally commited the changes.

Carnë Draug <carandraug>
Group Member
Mon 08 Apr 2013 09:20:02 PM UTC, comment #3: 

Attached is a patch where demos work on current octave release.

Pantxo

(file #27813)

Pantxo Diribarne <pantxo>
Group Member
Mon 08 Apr 2013 07:02:31 AM UTC, comment #2: 

I'll write new demos that don't depend on the patched imshow and submit a new patch.

Pantxo Diribarne <pantxo>
Group Member
Mon 08 Apr 2013 01:26:07 AM UTC, comment #1: 

I don't think it's a good idea to apply a patch that is dependent on a development version. This is dependent on a patch that hasn't even been accepted so I will wait until the other gets resolved and a new Octave version is out.

Is it possible to change this patch so that is not dependent on the other?

Carnë Draug <carandraug>
Group Member
Sun 07 Apr 2013 02:31:01 PM UTC, original submission:  

Attached is an svn changeset for imtransform related functions:
 - maketform is modified so as to accept input/output control points as second and third argument
 - findbounds is added,
 - imtransform is added.

The demos in imtransform currently rely on this patch http://savannah.gnu.org/patch/?7981
I know it is not a good idea to include features that may not be released for a while but without it, it becomes very difficult to have comprehensive demos.

Pantxo

Pantxo Diribarne <pantxo>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27964:  imtransform_tests.patch added by pantxo (4KiB - text/x-patch)
file #27813:  imtformpatch_r2.diff added by pantxo (19KiB - text/x-patch)
file #27805:  imtformpatch.diff added by pantxo (18KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-28 pantxo Attached File- Added imtransform_tests.patch, #27964
    2013-04-28 carandraug StatusNone Done
        Assigned toNone carandraug
        Open/ClosedOpen Closed
    2013-04-08 pantxo Attached File- Added imtformpatch_r2.diff, #27813
    2013-04-08 carandraug Summaryimtransform : various updates image package: imtransform - various updates
    2013-04-07 pantxo Attached File- Added imtformpatch.diff, #27805

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code