PSPP - Patches: patch #6512, Don't use isnan, isinf, finite
You are not allowed to post comments on this tracker with your current authentication level.
patch #6512: Don't use isnan, isinf, finite
Submitter: | Ben Pfaff <blp> | ||
Submitted: | Thu 15 May 2008 05:56:17 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | blp |
Open/Closed: | Closed |
Fri 16 May 2008 05:38:45 AM UTC, comment #5: |
Ben Pfaff <blp> |
Fri 16 May 2008 05:37:42 AM UTC, comment #4: See also additional discussion here:
|
Ben Pfaff <blp> |
Thu 15 May 2008 05:08:03 PM UTC, comment #3: Yes, that worked. |
Jason H Stover <jstover> |
Thu 15 May 2008 04:27:04 PM UTC, comment #2: Problems? Do you just mean trivially fixed patch rejects? I guess I'm OK with that. |
Ben Pfaff <blp> |
Thu 15 May 2008 06:55:31 AM UTC, comment #1: This will cause problems for anyone trying to apply patch #6245 but as that's not going to be part of 0.6.0 I suppose we shouldn't worry too much about that. |
John Darrington <jmd> |
Thu 15 May 2008 05:56:17 AM UTC, original submission:
isnan and isinf cause trouble on Solaris, and the gnulib replacements are not ready yet. Therefore, use gsl_isnan and gsl_isinf instead, which should work everywhere.
|
Ben Pfaff <blp> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-05-16 | blp | Status | Works For Me | Done | |
Open/Closed | Open | Closed | |||
2008-05-15 | jstover | Assigned to | jstover | blp | |
2008-05-15 | jstover | Status | Ready For Test/Review | Works For Me | |
2008-05-15 | blp | Attached File | - | Added isxxx.patch, #15666 |
Powered by Savane 3.13-f8d8.
Corresponding source code
I checked this in, so I'm closing it.
I'll file a bug separately about not using GSL for these functions.