patchGNU Octave - Patches: patch #8984, generate_html is not completely...

 
 

patch #8984: generate_html is not completely independent of octave-forge site

Submitter:  Fernando Pujaico Rivera <trucomanx>
Submitted:  Thu 21 Apr 2016 05:59:16 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 25 May 2016 06:17:30 PM UTC, comment #7: 

Please close this ticket.

Julien Bect <jbect>
Wed 25 May 2016 06:17:01 PM UTC, comment #6: 

The patch has been merged to default.

Julien Bect <jbect>
Tue 24 May 2016 12:05:29 AM UTC, comment #5: 

thanks by to accept the changes!

Fernando Pujaico Rivera <trucomanx>
Mon 23 May 2016 08:24:38 PM UTC, comment #4: 

I agree with the proposed change.

Actually, I would have sent this to the bug tracker, and not the patch tracker: the generate_html package is not supposed to be dedicated to Octave Forge only, and therefore this looks like a bug to me.

Anyway: I have pushed the patch to a feature branch and made some very minor changes.

I will merge to default in a few days unless someone has something more to say about this patch.

Julien Bect <jbect>
Sun 01 May 2016 09:03:16 AM UTC, comment #3: 

Thanks Julien! please see also my suggestion:

https://savannah.gnu.org/patch/?8988

About add installation/loading commands in the index.html

Fernando Pujaico Rivera <trucomanx>
Thu 21 Apr 2016 06:01:30 PM UTC, comment #2: 

Thank you Fernando, I will look into this as soon as time permits.

Julien Bect <jbect>
Thu 21 Apr 2016 05:33:42 PM UTC, comment #1: 

Adding package maintainer to CC.

Carnë Draug <carandraug>
Group Member
Thu 21 Apr 2016 05:59:16 AM UTC, original submission:  

I am trying make the documentation of my octave package, and this is no located in octave-forge site,
I am using a different repository.
I am using the function generate_package_html(), using the code:

options = get_html_options ("octave-forge");
# I got the options structure and
# I have modified the parameters interesting for me.
generate_package_html ("bsltl", "bsltl_html", options);

But, the function generate_package_html() internally has a code in the line 431 calling the link:

http://sourceforge.net/projects/octave/files/

It is the unique reference to a link in the file.
I need change this line, given that I am not using this repository.

I would like submit a modification over the definition of
this link in the get_html_options.m file, and moving this definition to the "options" structure.
Thus, others can make your documentations easily independently of repository site.

Joint with this message, I am sending a "diff file" with this modification in the add_var_older_versions_download.diff file.

In the modification, I have added the variable older_versions_download to the option structure in the get_html_options.m file

Fernando Pujaico Rivera <trucomanx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36972:  add_var_older_versions_download.diff added by trucomanx (2KiB - text/x-patch - Adding the variable older_versions_download to the option structure)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jbect (Posted a comment)
  • -email is unavailable- added by carandraug (Julien Bect - maintainer of generate_html package)
  • -email is unavailable- added by trucomanx (Submitted the item)
  • -email is unavailable- added by trucomanx (diff file submit)
  • -email is unavailable- added by trucomanx (diff file submit)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-05-25 carandraug StatusNone Done
        Open/ClosedOpen Closed
    2016-04-21 carandraug Carbon-Copy- Added -email is unavailable-
    2016-04-21 trucomanx Attached File- Added add_var_older_versions_download.diff, #36972
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code