patchPSPP - Patches: patch #8673, gtk3 - adapted pspp_sheet_view...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8673: gtk3 - adapted pspp_sheet_view draw routine to gtk_cairo_should_draw_window method

Submitter:  Friedrich Beckmann <beckmanf>
Submitted:  Sun 17 May 2015 01:15:24 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Mon 25 May 2015 08:43:41 AM UTC, comment #4: 
Friedrich Beckmann <beckmanf>
Group Member
Wed 20 May 2015 08:14:23 AM UTC, comment #3: 

This patch looks good.

I see that Ben has added you to the PSPP project, so you should now have permissions to push this yourself.

John Darrington <jmd>
Group administrator
Sun 17 May 2015 03:14:28 PM UTC, comment #2: 

Hi John,

i have attached an updated patch where also the return value and the name is changed. This reflects that it is not the expose but the draw method now. This is similar to that what is done in gtktreeview.

Friedrich

(file #34032)

Friedrich Beckmann <beckmanf>
Group Member
Sun 17 May 2015 02:21:28 PM UTC, comment #1: 

I haven't tried this, but it looks correct to me.

However, it seems that pspp_sheet_view_bin_expose now has no need of the return value.

I think perhaps it should be changed to return void.


John Darrington <jmd>
Group administrator
Sun 17 May 2015 01:15:24 PM UTC, original submission:  

This patch applies to gtk3. I tried this in debian 8 (jessie). The draw routine should not use if else if constructs but should check all of the multiple windows for redraw. See

https://developer.gnome.org/gtk3/stable/ch25s02.html#id-1.6.3.4.11

I also check for the existance of the dragwindow which produced gtk-critical messages in debian 8.




Friedrich Beckmann <beckmanf>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-25 beckmanf StatusNone Done
        Open/ClosedOpen Closed
    2015-05-17 beckmanf Attached File- Added gtk3-draw-new.patch, #34032
    2015-05-17 beckmanf Attached File- Added 0001-gtk3-adapted-draw-routine-to-gtk_cairo_should_draw_w.patch, #34029

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code