patchGNU Autoconf Archive - Patches: patch #8515, AX_GCC_ARCHFLAG: reorder option...

 
 

patch #8515: AX_GCC_ARCHFLAG: reorder option checking for Clang

Submitted by:  Tsukasa OI <a4lg>
Submitted on:  Fri Aug 15 09:51:01 2014  
 
Priority: 5 - NormalStatus: Done
Assigned to: Peter Simons <simons>Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Oct 15 09:10:10 2014, comment #2:

I pushed your patches in 7354d36 and 570de78. Thank you very much!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Mon Aug 25 04:40:31 2014, comment #1:

Added a workaround for Clang compiler.

[TODO]

We need support for C++. For various language support, requiring AC_PROG_CC in this macro may be inappropriate. But we have to check first whether removing this AC_REQUIRE causes issues before we do so.

(file #31957)

Tsukasa OI <a4lg>
Fri Aug 15 09:51:01 2014, original submission:

https://savannah.gnu.org/patch/index.php?8514

As I mentioned in the submission above, LLVM Clang support on this macro is partially corrupt because of different error handling from GCC.

For instance, in my Ivy Bridge environment with Clang compiler,

  • AX_GCC_ARCHFLAG([no]) selects option `-mcpu=ivybridge' which is not really supported by LLVM Clang
  • AX_GCC_ARCHFLAG([yes]) selects option `-mtune=ivybridge' which is not really support by LLVM Clang (as well)

This is because Clang does not fail on unknown processor type specified in -mcpu=... and -mtune=... options. This fix (changes order of option checking) does not resolve all the problems (AX_GCC_ARCHFLAG([yes]) still selects `-mtune=ivybridge') but it will solve some of them.

Please note that the submitted patch is expected to be applied after the patch #8514 but you could apply this patch first (with small modifications).

Tsukasa OI <a4lg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31957:  0002-AX_GCC_ARCHFLAG-add-workaround-for-Clang.patch added by a4lg (2kB - application/octet-stream - version 1 patchset patch 2 (after file #31904), Clang workaround)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by simons (Posted a comment)
  • -unavailable- added by simons
  • -unavailable- added by a4lg (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Oct 16 08:54:00 2014simonsStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Wed Oct 15 09:10:10 2014simonsStatusNone=>Ready For Test
      Assigned toNone=>simons
      Carbon-Copy-=>Added steven g. johnson
    Mon Aug 25 04:40:31 2014a4lgAttached File-=>Added 0002-AX_GCC_ARCHFLAG-add-workaround-for-Clang.patch, #31957
    Fri Aug 15 09:51:01 2014a4lgAttached File-=>Added 0001-AX_GCC_ARCHFLAG-reorder-option-checking-for-Clang.patch, #31904

    Back to the top


    Powered by Savane 3.1-cleanup1