patchGNU Octave - Patches: patch #8495, [octave forge] (signal) goertzel:...

 
 

patch #8495: [octave forge] (signal) goertzel: new function

Submitter:  None
Submitted:  Thu 10 Jul 2014 04:36:12 AM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Postponed Privacy:  Public
Assigned to:  mtmiller Originator Email:  -email is unavailable-
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 05 Apr 2018 09:25:27 PM UTC, comment #3: 

Dear Mike,

I am the original author of the code. you can quote Georg Egger as author's name, the email is still correct.

Sorry, I don't know how to modify the original code once submitted.

Anonymous
Wed 04 Apr 2018 10:07:17 PM UTC, comment #2: 

Postponed until we get a response from the original author about name for the copyright statement. I can't add code to the signal package that doesn't have a copyright attribution.

Mike Miller <mtmiller>
Group Member
Fri 30 Jan 2015 10:35:30 PM UTC, comment #1: 

Thanks for your patch submission. Sorry for the delay in taking a look at it.

Would you mind putting your full name in the copyright line of the source file? It would be preferable to credit the file to someone's real name if possible.

Would you be able to adjust the code to use Octave's coding style? See http://www.gnu.org/prep/standards/standards.html#Formatting and http://www.gnu.org/software/octave/doc/interpreter/C_002b_002b-Sources.html.

Would you be able to provide some test cases for the algorithm, in Octave's %!test format? This would help ensure that the function works correctly and continues to provide the right answers on all systems going forward.

This function can still be added to the signal package if you are not able to do any of these, but it would help speed things up if the file is made closer to being ready for inclusion.

Mike Miller <mtmiller>
Group Member
Thu 10 Jul 2014 04:36:12 AM UTC, original submission:  

implementation of görtzel algorithm (equivalent to matlab's one)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #31695:  goertzel.cc added by None (3KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 -
    2018-04-04 mtmiller StatusNeed Info Postponed
    2018-03-30 mtmiller CategoryNone Forge : new function
        Summarysignal package: goertzel function [octave forge] (signal) goertzel: new function
    2015-01-30 mtmiller StatusNone Need Info
        Assigned toNone mtmiller
        Summarysignal package signal package: goertzel function
    2014-07-10 None Attached File- Added goertzel.cc, #31695

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code