Gnash - The GNU Flash player - Patches: patch #8230, Patch for "Prefer prefix...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8230: Patch for "Prefer prefix ++/-- operators" (from cppcheck)
Submitter: | Julien Nabet <julien2412> | ||
Submitted: | Fri 01 Nov 2013 07:32:43 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Thu 16 Jan 2014 11:33:46 AM UTC, comment #5: |
Petter Reinholdtsen <pere> |
Thu 16 Jan 2014 11:10:13 AM UTC, comment #4: I actually hadn't read the patch, just the original submission, which made me think tree.hh was touched. Now I red the patch and it seems good to me. Feel free to commit, thanks ! |
Sandro Santilli <strk> |
Thu 16 Jan 2014 10:49:28 AM UTC, comment #3: The diffstat of the patch do not touch tree.hh, so I fail to see how the fact that it originates elsewhere should be relevant. Care to elaborate?
|
Petter Reinholdtsen <pere> |
Wed 15 Jan 2014 11:23:57 AM UTC, comment #2: The only reason would be that tree.hh is not ours. Check headers, best reported upstream and upgraded once fixed, or any patch of ours would be replaced on upgrade. |
Sandro Santilli <strk> |
Wed 15 Jan 2014 11:14:48 AM UTC, comment #1: The change make sense to me. Any reason not to apply it? It applies fairly cleanly to the git HEAD (with one fuzzy). |
Petter Reinholdtsen <pere> |
Fri 01 Nov 2013 07:32:43 AM UTC, original submission:
Hello
|
Julien Nabet <julien2412> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-01-16 | pere | Status | None | Done | |
Open/Closed | Open | Closed | |||
2013-11-01 | julien2412 | Attached File | - | Added patch_cppcheck.txt, #29522 |
Powered by Savane 3.13-4448.
Corresponding source code
I've commited the patch.