Gnash - The GNU Flash player - Patches: patch #7961, Fix for issues with youtube in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7961: Fix for issues with youtube in NetStream_as.cpp
Submitter: | George Thomas <georgethomas> | ||
Submitted: | Fri 01 Mar 2013 11:47:12 AM UTC | ||
Category: | core | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Thu 05 Sep 2013 10:43:40 AM UTC, comment #4: |
George Thomas <georgethomas> |
Wed 04 Sep 2013 08:53:10 PM UTC, comment #3: Can this be closed ? I believe the class vs. instance variable thing has been sorted out and put under testing.
|
Sandro Santilli <strk> |
Fri 01 Mar 2013 10:08:36 PM UTC, comment #2: I dug into the new testsuite failures caused by these last two patches. The basics of these patches appears correct, but part of the problem is the support for these isn't implemented in NetStream. For example, NetStream::getCurrentFPS() is hardcoded to always return 0. There are some weird behaviours going on as well. Although these are readonly properties, the current NetStream.as test case tries to set them to both a string and boolean value, and then expects the return value when the NetStream isn't connected to be the same as the object it was previous set too. When the test case is run with the Adobe player, it has this behaviour, so the tests pass. I'm not sure if that needs to be the same behaviour in Gnash. The support for these new properties needs to be implemented before most of these tests will pass. |
Rob Savoye <rsavoye> |
Fri 01 Mar 2013 07:26:04 PM UTC, comment #1: Committed as of #e309f67f4436abd1fa7d31981b556ee66052113e. |
Rob Savoye <rsavoye> |
Fri 01 Mar 2013 11:47:12 AM UTC, original submission:
Converting prototype members into members of the object when flash7 and above are used.
|
George Thomas <georgethomas> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-09-05 | strk | Status | In Progress | Done | |
Assigned to | rsavoye | strk | |||
Open/Closed | Open | Closed | |||
2013-03-01 | rsavoye | Status | Done | In Progress | |
Open/Closed | Closed | Open | |||
2013-03-01 | rsavoye | Status | Works For Me | Done | |
Assigned to | None | rsavoye | |||
Open/Closed | Open | Closed | |||
2013-03-01 | georgethomas | Attached File | - | Added youtubefix.patch, #27551 | |
Carbon-Copy | - | Added -email is unavailable- | |||
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-f8d8.
Corresponding source code
Yeah sure it can be.