patchGNU Autoconf Archive - Patches: patch #7601, ax_lib_sqlite3 could use C...

 
 

patch #7601: ax_lib_sqlite3 could use C compiler to check for the library but not the C++ compiler

Submitter:  Hong Xu <xuhdev>
Submitted:  Wed 24 Aug 2011 10:25:49 AM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 29 Aug 2011 10:13:49 AM UTC, comment #3: 
Peter Simons <simons>
Group administrator
Wed 24 Aug 2011 12:20:14 PM UTC, comment #2: 

OK I was wrong about that. Just change the AC_LANG_PUSH and AC_LANG_POP and that'll be ok.

Hong Xu <xuhdev>
Wed 24 Aug 2011 11:52:37 AM UTC, comment #1: 

Thank you very much for the patch.

I noticed that it modifies use of CPPFLAGS to CFLAGS in a number of places, and I wonder whether that is really what you intented to do. CPPFLAGS is for flags that ought to be passed to pre-processor; those flags are used by both the C and the C++ compiler. (C++-specific flags are stored in CXXFLAGS). So, it shouldn't be necessary to use CFLAGS instead of CPPFLAGS to check for sqlite3 with the C compiler. Arguably, it's even wrong to put "-I" options into CFLAGS (although it is probably going to work).

In other words, switching use of CPPFLAGS to CFLAGS seems to be unnecessary for what your patch is trying to accomplish.

Peter Simons <simons>
Group administrator
Wed 24 Aug 2011 10:25:49 AM UTC, original submission:  

Currently, ax_lib_sqlite3 is using C++ compiler to check the library. In fact, C compiler is enough. The attached file is the patch to fix this.

Hong Xu <xuhdev>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23856:  ax_lib_sqlite3.m4.patch added by xuhdev (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by simons
  • -email is unavailable- added by xuhdev (Submitted the item)
  •  

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-09-05 simons StatusReady For Test Done
        Open/ClosedOpen Closed
    2011-08-29 simons StatusNeed Info Ready For Test
    2011-08-24 simons StatusNone Need Info
        Assigned toNone simons
        Carbon-Copy- Added mateusz loskot <mateusz@loskot.net>
    2011-08-24 xuhdev Attached File- Added ax_lib_sqlite3.m4.patch, #23856

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code