patchfindutils - Patches: patch #3701, Additional tweaks for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3701: Additional tweaks for -execdir/-okdir actions

Submitted by:  Dmitry V. Levin <ldv>
Submitted on:  Mon 31 Jan 2005 03:58:56 PM UTC  
 
Category:  find enhancement Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  James Youngman <jay> Originator Name: 
Open/Closed:  Closed Release:  None
Fixed Release:  None

Wed 04 May 2005 10:57:26 PM UTC, comment #4: 

Additional documentation tweaks for -execdir/-okdir actions.

Dmitry V. Levin <ldv>
Sun 06 Feb 2005 09:16:54 AM UTC, comment #3: 

There are sharp limits on the amount of code I can accept into findutils before the copyright assignment process is complete.  This is inconvenient but it's FSF policy.  Therefore I have applied part of your patch to squeak under this limit.  The [atch I actually applied is attached.  I will have to defer applying the rest of the patch until the assignment process is complete.   Thanks for your understanding.

The patch I applied (which I have attached) was formed just by removing parts from "update for 4.2.16, take 2".   I realise this creates more work for you.  Sorry.

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 06 Feb 2005 12:13:11 AM UTC, comment #2: 

I still think that state.rel_pathname is the same as basename(pathname) inside pred_execdir and pred_okdir.

Dmitry V. Levin <ldv>
Mon 31 Jan 2005 09:09:52 PM UTC, comment #1: 

One more fix is required.

  • find/pred.c (pred_execdir, pred_okdir): Use state.rel_pathname

instead of basename(pathname) since later is incorrect in this context.
Do not add "./" prefix for absolute pathnames.

Test case:
$ findutils-4.2.15/find/find /usr/bin -mindepth 0 -maxdepth 0 -type d -execdir echo \{\} \;
./bin
$ find /usr/bin -mindepth 0 -maxdepth 0 -type d -execdir echo \{\} \;
/usr/bin

Dmitry V. Levin <ldv>
Mon 31 Jan 2005 03:58:56 PM UTC, original submission:  

This patch disables ignore_readdir_race for -execdir/-okdir, and additionally documents recently added options.

Dmitry V. Levin <ldv>

 

Attached Files
file #8795:  findutils-4.2.18-alt-find-execdir-okdir.patch added by ldv (5KiB - rest of original patch)
file #8377:  findutils-4.2.16-alt-find-execdir-okdir-jy-applied.patch added by jay (1KiB - text/x-patch - Patch I actually applied)
file #8375:  findutils-4.2.16-alt-find-execdir-okdir.patch added by ldv (6KiB - update for 4.2.16, take 2)
file #8347:  findutils-4.2.15-alt-find-execdir-okdir.patch added by ldv (6KiB - tweaks and fixes for -execdir/-okdir, take 2)
file #8343:  findutils-4.2.15-alt-find-execdir-okdir.patch added by ldv (5KiB - more tweaks for -execdir/-okdir)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 9 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-05-04 ldv Attached File- => Added findutils-4.2.18-alt-find-execdir-okdir.patch, #4566
2005-02-06 jay StatusNone => Done
    Open/ClosedOpen => Closed
2005-02-06 jay Assigned toNone => jay
    Attached File- => Added findutils-4.2.16-alt-find-execdir-okdir-jy-applied.patch, #4152
2005-02-06 ldv Attached File- => Added findutils-4.2.16-alt-find-execdir-okdir.patch, #4150
2005-02-06 ldv Attached File- => Added findutils-4.2.16-alt-find-execdir-okdir.patch, #4148
2005-01-31 ldv Attached File- => Added findutils-4.2.15-alt-find-execdir-okdir.patch, #4123
2005-01-31 ldv Attached File- => Added findutils-4.2.15-alt-find-execdir-okdir.patch, #4119

Back to the top


Powered by Savane 3.5