patchThe GNU Hurd - Patches: patch #3329, -1 is cast to uint32_t instead of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3329: -1 is cast to uint32_t instead of store_offset_t

Submitter:  Ognyan Kulev <ogi>
Submitted:  Wed 01 Sep 2004 06:50:17 AM UTC
   
 
Category:  Ext2 filesystem Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  marcus Open/Closed:  Closed
Planned Release:  None
Wiki-like text discussion box: 


Mon 08 Nov 2004 04:36:10 PM UTC, comment #1: 

Applied the patch, good catch!  Does this fix an actual bug?

I am a bit worried there may be more of such off64_t issues.  I hope not, but I didn't check thoroughly.

Marcus Brinkmann <marcus>
Group administrator
Wed 01 Sep 2004 06:50:17 AM UTC, original submission:  

Conditional operator ?: wants 2nd and 3rd arguments to be of the same type.  So the following use:

run->start = block ?: -1;

implicitly casts -1 to uint32_t, but it should be cast to store_offset_t.

Ognyan Kulev <ogi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #7820:  storeinfo.patch added by ogi (779B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-11-08 marcus CategoryNone Ext2 filesystem
    StatusNone Done
    Assigned toNone marcus
    Open/ClosedOpen Closed
2004-09-01 ogi Attached File- Added storeinfo.patch, #3624

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code