patchThe GNU Hurd - Patches: patch #2957, HURD_IHASH_ITERATE can loop...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #2957: HURD_IHASH_ITERATE can loop infinitely

Submitter:  Ognyan Kulev <ogi>
Submitted:  Wed 21 Apr 2004 07:46:40 PM UTC
   
 
Category:  libihash Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  marcus Open/Closed:  Closed
Planned Release:  None
Wiki-like text discussion box: 


Wed 21 Apr 2004 09:39:42 PM UTC, comment #1: 

Thanks for the report.

I made the change, but because I originally thought it was a bug report rather than a patch, I didn't check first and thus the changelog entry differs (the change is identical to yours, though).

2004-04-21  Marcus Brinkmann  <marcus@gnu.org>
                                                                               
        * ihash.h (HURD_IHASH_ITERATE): Don't use increment operator in
        assignment, but just add one.  Reported by Ognyan Kulev.

In any case, good catch!

Thanks,
Marcus

Marcus Brinkmann <marcus>
Group administrator
Wed 21 Apr 2004 07:46:40 PM UTC, original submission:  

For advancing _hurd_ihash_valuep, the following pattern is used: v=v++. This can loop inifinitely, depending on the mood of the compiler. It should be v=v+1.

Ognyan Kulev <ogi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #7307:  ihash.patch added by ogi (631B - text/x-patch - Patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-04-21 marcus StatusNone Done
    Assigned toNone marcus
    Open/ClosedOpen Closed
2004-04-21 ogi Attached File- Added ihash.patch, #3130

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code