patchGNU Octave - Patches: patch #9658, mapping package: geodetic2ecef,...

 
 

patch #9658: mapping package: geodetic2ecef, ecef2geodetic

Submitter:  None
Submitted:  Mon 18 Jun 2018 06:45:49 AM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  philipnienhuis Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 30 Sep 2018 11:01:14 AM UTC, comment #3: 

I've overhauled the functions to be able to just skip the first spheroid argument as matlab's version can. I've also added an alternative input arg order for geodetic2ecef, again just like matlab's.
In addition I've amended these functions to accept vectors and matrices for coordinate input, again like ..... (no I won't repeat).

Pushed here after some style edits:
http://hg.code.sf.net/p/octave/mapping/rev/71d56282ef95

Thanks again Anonymous for your contributions !

Closing as "Done"

Philip Nienhuis <philipnienhuis>
Group Member
Mon 24 Sep 2018 07:52:31 PM UTC, comment #2: 

thanks, looks much better.

I've already amended rcurve.m to skip type and start with ellipsoid  as first arg, just as the competition does.

Philip Nienhuis <philipnienhuis>
Group Member
Fri 21 Sep 2018 09:04:33 PM UTC, comment #1: 

Please fix style:
- double quotes instead of single quotes
- no spacesbefor a comma separating arguments, no spaces after ( o before ) (same for curly brackets). So:

case { 'meridian' }
...should rather be:
case {"meridian"}

and so on.

Thanks

Philip Nienhuis <philipnienhuis>
Group Member
Mon 18 Jun 2018 06:45:49 AM UTC, original submission:  
Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45080:  rcurve.m added by None (3KiB - application/octet-stream - updated versions)
file #45081:  ecef2geodetic.m added by None (4KiB - application/octet-stream - updated versions)
file #45082:  geodetic2ecef.m added by None (3KiB - application/octet-stream - updated versions)
file #44390:  rcurve.m added by None (3KiB - text/x-objcsrc)
file #44388:  ecef2geodetic.m added by None (4KiB - text/x-objcsrc)
file #44389:  geodetic2ecef.m added by None (3KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 11 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2018-09-30 philipnienhuis StatusIn Progress Done
    Open/ClosedOpen Closed
2018-09-24 philipnienhuis CategoryNone Forge : new function
2018-09-24 philipnienhuis StatusNone In Progress
2018-09-24 None Attached File- Added rcurve.m, #45080
    Attached File- Added ecef2geodetic.m, #45081
    Attached File- Added geodetic2ecef.m, #45082
2018-07-09 philipnienhuis Assigned toNone philipnienhuis
2018-06-18 None Attached File- Added rcurve.m, #44390
2018-06-18 None Attached File- Added ecef2geodetic.m, #44388
    Attached File- Added geodetic2ecef.m, #44389

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code