patchLibreDWG - Patches: patch #9590, fix the api, examples and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9590: fix the api, examples and unit-tests

Submitted by:  Reini Urban <reini_urban>
Submitted on:  Mon 12 Mar 2018 03:25:46 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Reini Urban <reini_urban> Open/Closed:  Closed

Mon 12 Mar 2018 03:29:15 PM UTC, comment #2: 

The patches are also at https://github.com/rurban/libredwg
in the work branch.

Reini Urban <reini_urban>
Project AdministratorIn charge of this item.
Mon 12 Mar 2018 03:28:01 PM UTC, comment #1: 

Waiting for the FSF papers to sign. Sent the mail request yesterday.

Reini Urban <reini_urban>
Project AdministratorIn charge of this item.
Mon 12 Mar 2018 03:25:46 PM UTC, original submission:  

In addition to #9588 this series of patches fixes the api and fixes encode with insert_handles.

      add missing checks for an empty 2nd arg
      add missing return values in the error case.
      LOG_ERROR

      declare all accessors, fixing x86_64
      E.g. fixing http://lists.gnu.org/archive/html/libredwg/2017-07/msg00000.html
      caused by the wrong default type being added for the undeclared functions, capping
      pointers at 32bit.

      change TV from unsigned char* to char*, only the internal
      methods need to use unsigned char*. harmonized with the external field types.

      changed get_block_size accessors to return the natural unsigned long type, not
      long *.

      change API to return pointers, not structs for:
      dwg_obj_appid_get_appid_control, dwg_obj_get_handle, dwg_ent_insert_get_ref_handle

Reini Urban <reini_urban>
Project AdministratorIn charge of this item.

 

Attached Files
file #43528:  0006-dwg.spec-handle-insert_count.patch added by reini_urban (11KiB - application/octet-stream)
file #43524:  0002-fix-dwg_api.patch added by reini_urban (950KiB - application/octet-stream)
file #43526:  0003-fixup-examples.patch added by reini_urban (13KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by reini_urban (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-25 reini_urban StatusNone => Done
        Assigned toNone => reini_urban
        Open/ClosedOpen => Closed
    2018-03-12 reini_urban Attached File- => Added 0006-dwg.spec-handle-insert_count.patch, #43528
        Attached File- => Added 0007-dwg.spec-ANYCODE-for-parent-next-prev.patch, #43529
    2018-03-12 reini_urban Attached File- => Added 0002-fix-dwg_api.patch, #43524
        Attached File- => Added 0004-xmlsuite-unsigned-char-conversion.patch, #43525
        Attached File- => Added 0003-fixup-examples.patch, #43526
        Attached File- => Added 0005-dwg.spec-layout_handle-in-BLOCK_HEADER-is-code-5.patch, #43527

    Back to the top


    Powered by Savane 3.7