patchGNU nano - Patches: patch #9474, tweaks: avoid translating help...


You are not allowed to post comments on this tracker with your current authentication level.

patch #9474: tweaks: avoid translating help descriptions unnecessarily

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Fri 27 Oct 2017 05:14:43 PM UTC  
Priority:  3 - Low Status:  Done
Privacy:  Public Assigned to:  Benno Schulenberg <bens>
Open/Closed:  Closed Release:  None

Sat 28 Oct 2017 10:41:25 AM UTC, comment #1:

Ehm... The N_() is a no-op function. The reason it was there is that I carried this patch locally for some years, with the description string plugged in right there. When I integrated the patch into nano, I made the string into a constant but forgot to remove the now superfluous N_(). Thanks for noticing and reporting. Fixed in git, d84fb8d2.

(And I've taken the opportunity to change in subsequent commits a bunch of other things that have bothered me for a long time.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 27 Oct 2017 05:14:43 PM UTC, original submission:

Currently, as of git 14bf53d, there's one statement in global.c:986 that doesn't translate the help description for the shortcut:

add_to_funcs(do_search_backward, MMAIN,
N_("Where Was"), IFSCHELP(N_(nano_wherewas_msg)), BLANKAFTER, VIEW);

None of the other add_to_funcs() calls in that function do this. However, making them all do this doesn't cause any harm, since the help descriptions are only actually run through gettext() in help.c:help_init(); I've tested this by building git with --prefix=/usr and switching languages via setting LC_ALL.

The attached patch accomplishes this, by redefining the IFSCHELP() macro to not translate any help descriptions (and by removing the one case where it's done directly).

David Lawrence Ramsey <dolorous>
Project Administrator



Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-19 bens Open/ClosedOpen => Closed
    2017-10-28 bens Priority5 - Normal => 3 - Low
        StatusNone => Done
        Assigned toNone => bens
    2017-10-27 dolorous Attached File- => Added 0001-shortcuts-use-N_-around-all-shortcut-descriptions.patch, #42279

    Back to the top

    Powered by Savane 3.3