patchGNU nano - Patches: patch #9465, tweaks: fix missing parentheses...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9465: tweaks: fix missing parentheses around ISSET macro

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Sun 15 Oct 2017 07:41:22 PM UTC  
 
Priority: 3 - LowStatus: Done
Privacy: PublicAssigned to: David Lawrence Ramsey <dolorous>
Open/Closed: ClosedRelease: None

Thu 19 Oct 2017 07:40:42 PM UTC, comment #5:

Last version of the patch has been pushed, f8c75c43. Thanks.

Benno Schulenberg <bens>
Project Administrator
Tue 17 Oct 2017 11:22:17 PM UTC, comment #4:

Further addendum: the attached patch should be better.

(After some more thought, since ^W file browser search always goes forward with no way to toggle that, M-W file browser "search again" should always go forward as well. This means that there should be no changes to the file browser, or anywhere outside search.c, so this version contains the minimal changes required.)

(file #42187)

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Mon 16 Oct 2017 08:19:26 PM UTC, comment #3:

Addendum: would the patch to do what you want be something like the attached (which also works for file browser searches)? It's against git 58ecc03.

(file #42172)

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Mon 16 Oct 2017 07:49:46 PM UTC, comment #2:

No problem.

So, if I understand you correctly, you'd change things so that:

1. Alt-Up always searches backwards.

2. Alt-Down always searches forwards.

3. Meta-W always searches in whatever direction the previous search was in (which is forwards if there is no last search).

If that's what you mean, that sounds good to me, since "Search Again" doesn't imply a direction anyway, and the new way is clearer.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Mon 16 Oct 2017 06:02:15 PM UTC, comment #1:

Thanks for noticing this.

However... I think those ifs have become superfluous. Because I think the user would use either M-W (searchagain) or Alt+Up/Alt+Down (findprevious/findnext), or self-made bindings for the latter. They will either have a mindset that toggles the search direction and then uses M-W always, or they don't want to remember any state and use findprev/findnext always. In either case it is okay that do_findprevious() and do_findnext() do not remember and restore the setting of BACKWARDS_SEARCH -- they can just set it to what is needed and be done with it, just like do_search_forward() and do_search_backward(). And even if there are users that mix the usage of Alt+Up/Alt+Down with M-W, I don't think its strange that M-W goes in the same direction as the last used Alt+Up/Down keys. Yes, it will be a change in behavior from since findprevious and findnext were made, but... I think it will be better: no funky state: M-W will always search in the direction that was last used. What do you think?

Benno Schulenberg <bens>
Project Administrator
Sun 15 Oct 2017 07:41:22 PM UTC, original submission:

do_findprevious() and do_findnext() both contain the if statement

if ISSET(BACKWARDS_SEARCH)

While this does work, because the ISSET macro is defined to be surrounded by parentheses anyway, it will break if the definition changes to not do so.

Furthermore, this means that searching for "if (ISSET(" will find all if statements containing the ISSET macro except for these two, which I think is more of a problem (even if the change is effectively cosmetic).

The attached patch, against git 501d05c, changes these to

if (ISSET(BACKWARDS_SEARCH))

to match the rest of the code.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 19 Nov 2017 10:28:03 AM UTCbensOpen/ClosedOpen=>Closed
    Thu 19 Oct 2017 07:40:42 PM UTCbensStatusNone=>Done
      Assigned toNone=>dolorous
    Tue 17 Oct 2017 11:22:17 PM UTCdolorousAttached File-=>Added 0001-search-make-Search-Again-always-use-the-previous-sea.patch, #42187
    Mon 16 Oct 2017 08:19:26 PM UTCdolorousAttached File-=>Added 0001-search-make-Search-Again-always-use-the-previous-sea.patch, #42172
    Mon 16 Oct 2017 06:02:15 PM UTCbensPriority5 - Normal=>3 - Low
    Sun 15 Oct 2017 07:41:22 PM UTCdolorousAttached File-=>Added 0001-tweaks-fix-missing-parentheses-around-ISSET-macro.patch, #42161

    Back to the top


    Powered by Savane 3.1-cleanup1