patchGNU Octave - Patches: patch #9310, rotx, roty, and rotz...

 
 

patch #9310: rotx, roty, and rotz implementations for geometry vector rotation

Submitter:  Nicholas Jankowski <nrjank>
Submitted:  Tue 11 Apr 2017 08:17:24 PM UTC
   
 
Category:  Core : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 14 Dec 2019 12:10:50 PM UTC, comment #5: 

No complaints since July. Closing this report as done.

Markus Mützel <mmuetzel>
Group administrator
Sun 21 Jul 2019 03:51:11 PM UTC, comment #4: 

I pushed your patch with minor changes here:
http://hg.savannah.gnu.org/hgweb/octave/rev/f49226d21c26

The manual didn't build with the original patch. It turns out we cannot use \mathbf in TeX blocks.
I also had to remove the "see also" links to functions that aren't part of core Octave.

Markus Mützel <mmuetzel>
Group administrator
Fri 22 Mar 2019 07:48:18 PM UTC, comment #3: 

ok. updated patch, made mods suggested to all three. new patch attached

(file #46624)

Nicholas Jankowski <nrjank>
Group Member
Sat 02 Mar 2019 10:03:26 AM UTC, comment #2: 

These functions aren't part of core Matlab. But they would be handy to have in core Octave anyway, imho.

The functions themselves look good at a quick glance.

Could you please rebase the patch to the current default branch?

Also don't use tab for indentations and remove trailing spaces.
In the docstrings for the functions, could you please add whether the given sense of rotation is for an active or passive rotation and for multiplication from the left or from the right?
Maybe you could also include a vector in the example.

Markus Mützel <mmuetzel>
Group administrator
Fri 22 Feb 2019 08:24:17 PM UTC, comment #1: 

looking through my old items list and wondering if this patch is too stale to push? Does it need a refresh?

Nicholas Jankowski <nrjank>
Group Member
Tue 11 Apr 2017 08:17:24 PM UTC, original submission:  

as discussed in Bug #50772 [1], attached is an implementation of vector rotation matrix generations functions rotx, roty, rotz.  It was suggested that these be made part of octave core.  the attached patch places the functions in /scripts/geometry.  Also updates the local modules.mk, adds a vector rotations section to geometry.txi, and adds the function names to NEWS.


[1] https://savannah.gnu.org/bugs/?50772


Nicholas Jankowski <nrjank>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46624:  add_rotxyz_tocore_v3.diff added by nrjank (12KiB - application/octet-stream - brought up to date, added examples & clarifications)
file #40366:  add_rotxyz_tocore_v2.diff added by nrjank (10KiB - application/octet-stream - corrected patch message)
file #40362:  add_rotxyz_tocore.diff added by nrjank (10KiB - application/octet-stream)
file #40363:  roty.m added by nrjank (2KiB - application/octet-stream)
file #40364:  rotx.m added by nrjank (2KiB - application/octet-stream)
file #40365:  rotz.m added by nrjank (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by nrjank (Submitted the item)
  • -email is unavailable- added by nrjank
  • -email is unavailable- added by nrjank
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-12-14 mmuetzel StatusReady For Test Done
        Open/ClosedOpen Closed
    2019-07-21 mmuetzel StatusNone Ready For Test
    2019-03-22 nrjank Attached File- Added add_rotxyz_tocore_v3.diff, #46624
    2017-04-11 nrjank Attached File- Added add_rotxyz_tocore_v2.diff, #40366
    2017-04-11 nrjank Attached File- Added add_rotxyz_tocore.diff, #40362
        Attached File- Added roty.m, #40363
        Attached File- Added rotx.m, #40364
        Attached File- Added rotz.m, #40365
        Carbon-Copy- Added juanpi
        Carbon-Copy- Added rik

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code