GNU nano - Patches: patch #9295, fix UTF-8-related function checks...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9295: fix UTF-8-related function checks in configure.ac
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Thu 23 Mar 2017 07:35:34 PM UTC | ||
Priority: | 3 - Low | Status: | Done |
Privacy: | Public | Assigned to: | dolorous |
Open/Closed: | Closed | Release: | None |
Sun 26 Mar 2017 10:57:34 AM UTC, comment #4: |
Benno Schulenberg <bens> |
Sat 25 Mar 2017 01:23:58 AM UTC, comment #3: Copy-and-paste error. The list of checks in the last comment should be:
|
David Lawrence Ramsey <dolorous> |
Sat 25 Mar 2017 12:06:22 AM UTC, comment #2: Okay. The attached (updated) patch removes the checks for iswspace and iswblank. With it applied, the remaining checks for UTF-8 support in configure.ac (aside from a wide version of curses, of course) are:
|
David Lawrence Ramsey <dolorous> |
Fri 24 Mar 2017 08:16:42 PM UTC, comment #1: In commit 63cae0c1 Mike removed the checks for isblank and iswblank because we now import the relevant gnulib modules, so those functions always are available. If iswspace was only used if iswblank was absent... it means that the check for iswspace can simply be removed, and the corresponding condition too.
|
Benno Schulenberg <bens> |
Thu 23 Mar 2017 07:35:34 PM UTC, original submission:
In current git (9e7e88e), when checking for UTF-8 support, configure.ac checks for either iswblank() or iswspace(). However, before gnulib support was added, iswspace() was only used in nano when iswblank() was unavailable, as part of the replacement function for it. Since gnulib provides iswblank() now, a check for iswspace() is no longer needed. (Also, a later check for UTF-8 related functions incorrectly checks only for iswspace(), not iswblank().) The attached patch fixes these issues. |
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-04-02 | bens | Open/Closed | Open | Closed | |
2017-03-26 | bens | Status | In Progress | Done | |
Assigned to | None | dolorous | |||
2017-03-25 | dolorous | Attached File | - | Added 0001-configure-fix-UTF-8-related-function-checks.patch, #40118 | |
2017-03-24 | bens | Priority | 5 - Normal | 3 - Low | |
Status | None | In Progress | |||
2017-03-23 | dolorous | Attached File | - | Added 0001-configure-fix-UTF-8-related-function-checks.patch, #40097 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Thanks. Applied in git, 0276e454, with some message tweaks.