GNU nano - Patches: patch #9267, fix an inefficiency in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9267: fix an inefficiency in display_string()
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Thu 23 Feb 2017 04:55:29 PM UTC | ||
Priority: | 5 - Normal | Status: | Done |
Privacy: | Public | Assigned to: | dolorous |
Open/Closed: | Closed | Release: | None |
Fri 24 Feb 2017 08:54:24 PM UTC, comment #3: |
David Lawrence Ramsey <dolorous> |
Fri 24 Feb 2017 10:14:40 AM UTC, comment #2: Thanks for the patch. A tweaked version was pushed, f1d214c0.
|
Benno Schulenberg <bens> |
Thu 23 Feb 2017 08:27:40 PM UTC, comment #1: As long as I'm looking at this, as an aside, there's also this bit of code near the end of display_string(), which you added in commit 0894587:
|
David Lawrence Ramsey <dolorous> |
Thu 23 Feb 2017 04:55:29 PM UTC, original submission:
In current git, in display_string(), converted is allocated space for the entire buffer (also involving a strlen(), so the entire string is scanned). However, immediately afterwards, the buffer is shifted forward to start_index and displayed from there; nothing before start_index is looked at again past that point.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-04-02 | bens | Open/Closed | Open | Closed | |
2017-02-24 | bens | Status | None | Done | |
Assigned to | None | dolorous | |||
2017-02-23 | dolorous | Attached File | - | Added 0001-tweaks-fix-an-inefficiency-in-display_string.patch, #39815 |
Powered by Savane 3.13-d3ae.
Corresponding source code
No problem. And yes, mb_cur_max() should be 4; I was thinking MB_CUR_MAX.