patchGNU Octave - Patches: patch #9018, package generate_html: some fixes...

 
 

patch #9018: package generate_html: some fixes to generate_package_html.m

Submitter:  Olaf Till <i7tiol>
Submitted:  Fri 03 Jun 2016 07:02:22 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 31 Jan 2017 05:41:18 PM UTC, comment #7: 

Really, this ticket can be closed ;-)

Julien Bect <jbect>
Thu 14 Jul 2016 08:50:44 AM UTC, comment #6: 

This ticket can be closed.

Julien Bect <jbect>
Thu 14 Jul 2016 08:50:20 AM UTC, comment #5: 

Olaf,

I have reviewed your four changesets.

I have backed out the one that copies CSS file such as ../../octave-forge.css.  In don't believe such files should be included in the documentation directory.

The other three changesets are fine.

@++
Julien

Julien Bect <jbect>
Tue 14 Jun 2016 06:45:46 PM UTC, comment #4: 

So I pushed the changesets for now. I'll look at further unwind-protects later.

Olaf Till <i7tiol>
Group Member
Sun 12 Jun 2016 05:54:08 PM UTC, comment #3: 


> Sun 12 Jun 2016 05:00:43 PM UTC, comment #2:
>
> > 1. Sure, I intended to do this as well, thanks for doing it
> > first.
>
> Ok, so my meddling in was not necessary. But I felt a bit responsible for this subfunction.


On the contrary.

I don't have much time to devote to generate_html these days, so I'm glad you did it.

Julien Bect <jbect>
Sun 12 Jun 2016 05:00:43 PM UTC, comment #2: 


> 1. Sure, I intended to do this as well, thanks for doing it
> first.


Ok, so my meddling in was not necessary. But I felt a bit responsible for this subfunction.

to 3.:

There are generated references to ../../octave-forge.css, and as I understood from the previous posts, the current idea is to sometimes provide such a file even locally. Maybe I'm wrong here.

Olaf Till <i7tiol>
Group Member
Sun 12 Jun 2016 02:48:36 PM UTC, comment #1: 

Thanks, I will look at your patches soon.  A few comments already:

1. Sure, I intended to do this as well, thanks for doing it first.

2. I agree that it might be necessary to do this in other places as well.  If you have time find where...

3. I'm not sure I understand this one.

4. Sure.

Julien Bect <jbect>
Fri 03 Jun 2016 07:02:22 PM UTC, original submission:  

attached file contains 4 changesets for package generate_html, generate_package_html.m, subfunction(s) copy_(images/css)

1. combined subfunctions to one, since almost identical

2. unwind_protect closing of opened file in this subfunction, since it might throw errors. This may be necessary at other places in generate_package_html also.

3. don't exclude paths containing '..' for stylesheets, since such paths are in.

4. check for presence of files to copy, since 'copyfiles' throws an error for lacking files, and the stylesheets might not be present

Olaf Till <i7tiol>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37382:  generate_html.csets added by i7tiol (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by jbect (Posted a comment)
  • -email is unavailable- added by jbect
  • -email is unavailable- added by jbect
  • -email is unavailable- added by i7tiol (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-31 mtmiller StatusNone Done
        Open/ClosedOpen Closed
    2016-06-12 jbect Carbon-Copy- Added jbect
        Carbon-Copy- Added
    2016-06-03 i7tiol Attached File- Added generate_html.csets, #37382

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code