patchGNU Octave - Patches: patch #8844, maint: variables.cc: invert...

 
 

patch #8844: maint: variables.cc: invert if/else/error instances.

Submitter:  Doug Stewart <dastew>
Submitted:  Wed 06 Jan 2016 07:56:44 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 09 Feb 2016 06:08:29 PM UTC, comment #2: 

I applied your patch and cleaned up some other instances in variables.cc (http://hg.savannah.gnu.org/hgweb/octave/rev/2e64b5899d1f).  Thanks, closing patch report as Done.

Rik <rik5>
Group administrator
Tue 09 Feb 2016 06:01:14 PM UTC, comment #1: 

This can be closed Rik implemented the changes.

Doug Stewart <dastew>
Wed 06 Jan 2016 07:56:44 PM UTC, original submission:  

Variables.cc

In this file at about line 807

       default:
          error ("%s: argument must be a single character", nm);
          break;

Do we still need the "break"

I left it in --- so if it is not used now the we should take it out.


Doug

Doug Stewart <dastew>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35936:  21045a.patch added by dastew (6KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by dastew (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-09 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2016-01-06 dastew Attached File- Added 21045a.patch, #35936

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code