patchGNU Octave - Patches: patch #8834, More files for code sprint topic #6

 
 

patch #8834: More files for code sprint topic #6

Submitter:  José Luis García Pallero <jgpallero>
Submitted:  Mon 14 Dec 2015 02:55:19 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 24 Dec 2015 03:52:28 PM UTC, comment #1: 

I think all of your patches was also done by cset c07bee629973.

I'm closing this since all files are fixed now: http://wiki.octave.org/Refactor_C%2B%2B_code_to_use_ovl%28%29_when_returning_multiple_values

Thank you for your contribution.

Andreas Weber <andy1978>
Group Member
Mon 14 Dec 2015 02:55:19 PM UTC, original submission:  

I attached patches for the files corefcn/ luinc.cc, filter.cc, allipj.cc and _qp_.cc refactored to use the ovl() function. I've tested the changes compiling the development sources and there are no errors.

Also, the file graphics.cc is listed in http://wiki.octave.org/Refactor_C%2B%2B_code_to_use_ovl%28%29_when_returning_multiple_values#Files as a working file, but the variable retval is of type Matrix in all the file, instead of octave_value_list. I think this file should be deleted from the list.

José Luis García Pallero <jgpallero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35741:  corefcn_ovl_jgpallero.tar.gz added by jgpallero (2KiB - application/gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by jgpallero (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-24 andy1978 Open/ClosedOpen Closed
    2015-12-14 jgpallero Attached File- Added corefcn_ovl_jgpallero.tar.gz, #35741

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code